-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(24.04): add slices for NGINX GeoIP modules and dependencies #439
feat(24.04): add slices for NGINX GeoIP modules and dependencies #439
Conversation
Diff of dependencies: slices/libnginx-mod-http-geoip.yaml@@ -1,3 +1,3 @@
libc6
libgeoip1t64
-nginx-abi-1.24.0-1
+nginx slices/libnginx-mod-http-geoip2.yaml@@ -1,4 +1,4 @@
libc6
libmaxminddb0
libnginx-mod-stream
-nginx-abi-1.24.0-1
+nginx slices/libnginx-mod-stream-geoip.yaml@@ -1,4 +1,4 @@
libc6
libgeoip1t64
libnginx-mod-stream
-nginx-abi-1.24.0-1
+nginx slices/libnginx-mod-stream-geoip2.yaml@@ -1,4 +1,4 @@
libc6
libmaxminddb0
libnginx-mod-stream
-nginx-abi-1.24.0-1
+nginx slices/libnginx-mod-stream.yaml@@ -1,2 +1,2 @@
libc6
-nginx-abi-1.24.0-1
+nginx |
fca3c6b
to
d320e12
Compare
d320e12
to
55b8a57
Compare
@cjdcordeiro Any news on when this can be merged? |
Hi @norrisjeremy ! Our team is still coming back to work after the holiday break, so please allow for a few days before we can get this through ;) I'm giving it a 1st pass today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty similar to #440 . Nothing to add. It LGTM, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
Proposed changes
feat(24.04): add slices for NGINX GeoIP modules and dependencies
Related issues/PRs
#440
Forward porting
Checklist
Additional Context