Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.10): add .NET9 slices #436

Merged

Conversation

zhijie-yang
Copy link
Collaborator

@zhijie-yang zhijie-yang commented Dec 16, 2024

Proposed changes

This PR add the slice definitions for .NET9 packages.

  • For the current chisel implementation, conflicts with .NET8 packages are worked around with /usr/lib/dotnet/dotnet9: {copy: /usr/lib/dotnet/dotnet}.

Forward porting

Not applicable.

Checklist

Copy link

Diff of dependencies:
None found.


@zhijie-yang zhijie-yang force-pushed the ROCKS-1307/dotnet-9.0-slices branch 4 times, most recently from 2a1db7b to 40344cc Compare December 17, 2024 16:14
@zhijie-yang zhijie-yang force-pushed the ROCKS-1307/dotnet-9.0-slices branch from 78b12a2 to 983e793 Compare December 17, 2024 23:20
@zhijie-yang zhijie-yang marked this pull request as ready for review December 17, 2024 23:33
@zhijie-yang zhijie-yang requested a review from a team December 17, 2024 23:33
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. And for the new tests ! LGTM

Copy link

@clay-lake clay-lake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few quick fixes, otherwise looks good!

tests/spread/integration/aspnetcore-runtime-9.0/task.yaml Outdated Show resolved Hide resolved
tests/spread/integration/aspnetcore-runtime-9.0/task.yaml Outdated Show resolved Hide resolved
tests/spread/integration/dotnet-runtime-9.0/task.yaml Outdated Show resolved Hide resolved
Copy link

@clay-lake clay-lake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! ☃️

@cjdcordeiro cjdcordeiro merged commit eb825bf into canonical:ubuntu-24.10 Dec 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants