Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic slice definitions files for Focal #42

Merged
merged 5 commits into from
Jul 14, 2023

Conversation

cjdcordeiro
Copy link
Collaborator

Duplicate of #41, with a different base branch.

This PR backports (from 22.04) and fits a few (the most basic and essential) slice definitions files into the new Focal Chisel release.

The affected packages are:

  • base-files
  • base-passwd
  • ca-certificates
  • libc6
  • libgcc-s1

The choice of packages was driven by our Chiselled Ubuntu base image.

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Thanks.

Although I would have wished the libc6_libs slice definition could be a bit shortened; some of the lines may be merged together. But that'd just increase the likelihood of missed errors. It's better to be explicit, for now at least.

@cjdcordeiro
Copy link
Collaborator Author

Looks good to me now. Thanks.

Although I would have wished the libc6_libs slice definition could be a bit shortened; some of the lines may be merged together. But that'd just increase the likelihood of missed errors. It's better to be explicit, for now at least.

Yeah I think we should change a bit our approach towards the usage of globs. I don't think we should be using them as a way to be "lazy" about writing the full paths or trying to merge multiple paths into one, but rather as a way to reduce path duplication due to metadata properties of the path (like the architecture or version). For example:

  • /usr/lib/*/libfoo*: IMO this is bad
  • /usr/lib/*-linux-*/libfoo-2.*.so: this is better

@cjdcordeiro cjdcordeiro merged commit c369f6f into canonical:ubuntu-20.04-proposed Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants