Rework of PR #49 "[22.04] Add slices for libgnutls, libsoup and glib-networking" #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archive version was being changed to 23.1 instead 23.10 for values with trailing zeroes. This commit fixes the bug. https://github.com/canonical/chisel-releases/actions/runs/8014505888/job/21893215155?pr=143
--------- Co-authored-by: Cristovao Cordeiro <[email protected]>
Co-authored-by: Cristovao Cordeiro <[email protected]>
Co-authored-by: Cristovao Cordeiro <[email protected]>
Currently we are running Installability Tests whenever a file inside ".github" directory is added or modified. We do not always need this. Instead, checking whether the relevant workflow file and scripts have changed is enough.
This commit adds a new reusable workflow which can be run on Pull Requests to see if the packages listed in "essential" of a slice are the true dependencies of the slice package. This workflow will add a PR comment if it finds any errors.
Bypassing the branch protection to commit this fix since it is a small fix that is blocking other PRs
* feat: add .gitignore file
The maximum length of a line is now 100.
--------- Co-authored-by: Rafid Bin Mostofa <[email protected]>
|
Diff of dependencies: |
|
The CI is failing. |
clay-lake
force-pushed
the
rework_add-networking-lib
branch
from
2822efa to
b939c9c
Compare
|
Github seemed to close this PR while I was attempting to squash commits for CI. I opened a new PR in its place #389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of #49, as it has not been updated in a while.
This PD adds the following changes:
publicsuffixis more explicit following earlier comments in [22.04] Add slices for libgnutls, libsoup and glib-networking #49glib-networkingand dependentgsettings-desktop-schemaswere removed. Since these packages related to the gnome desktop environment, I am hesitant to add them unless they can be tested in a minimal rootfs.