feat(24.04): add udev slice #378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff of dependencies: slices/udev.yaml@@ -7,5 +7,3 @@
libudev1
systemd
systemd-dev
-systemd-standalone-sysusers
-systemd-sysusers |
3 tasks
Meulengracht
force-pushed
the
slices/udev
branch
from
90c6064 to
4992732
Compare
…s are only valid on arm and x86
cjdcordeiro
requested changes
Nov 18, 2024
Comment on lines
+28
to
+35
| # This provides neccesary functionality to generate the hwdb | ||
| # for udev. In the postinst script the following command is run | ||
| # /usr/bin/systemd-hwdb --usr update. | ||
| # Currently we have the same challenge in terms of emulating what | ||
| # systemd-hwdb is doing, as it's writing very carefully constructed | ||
| # binary data to binary files. For more info on this we can check | ||
| # PR: https://github.com/canonical/chisel-releases/pull/329 where a | ||
| # similar challenge is. |
There was a problem hiding this comment.
Suggested change
| # This provides neccesary functionality to generate the hwdb | |
| # for udev. In the postinst script the following command is run | |
| # /usr/bin/systemd-hwdb --usr update. | |
| # Currently we have the same challenge in terms of emulating what | |
| # systemd-hwdb is doing, as it's writing very carefully constructed | |
| # binary data to binary files. For more info on this we can check | |
| # PR: https://github.com/canonical/chisel-releases/pull/329 where a | |
| # similar challenge is. | |
| # This provides the necessary functionality to generate the hwdb | |
| # for udev. In the postinst script the following command is run | |
| # /usr/bin/systemd-hwdb --usr update. | |
| # Currently we have the same challenge in terms of emulating what | |
| # systemd-hwdb is doing, as it's writing very carefully constructed | |
| # binary data to binary files. For more info on this, we can check | |
| # PR: https://github.com/canonical/chisel-releases/pull/329 where a | |
| # similar challenge is. |
| /usr/lib/udev/rules.d/81-net-dhcp.rules: | ||
| /usr/lib/udev/rules.d/90-iocost.rules: | ||
|
|
||
| systemd-udevd: |
There was a problem hiding this comment.
there's more than just udevd in this slice. Is this the right name?
cjdcordeiro
reviewed
Nov 18, 2024
| /usr/lib/systemd/system/udev.service: | ||
| /usr/lib/systemd/systemd-udevd: | ||
|
|
||
| sysusers-config: |
There was a problem hiding this comment.
Does this make sense without systemd-sysusers? Which is a dep missing from this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Proposing udev as its needed for Ubuntu Core. The slices is as well tested as I think make sense currently. Systemd-udevd is difficult to test as it requires a lot more system setup, and interacts with /dev devices.
Checklist