Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04): add debianutils #335

Open
wants to merge 1 commit into
base: ubuntu-24.04
Choose a base branch
from

Conversation

Meulengracht
Copy link
Member

Proposed changes

Add debianutils

Related issues/PRs

Forward porting

Can open for 24.10 if approved

Checklist

Copy link

github-actions bot commented Sep 4, 2024

Diff of dependencies:
None found.


contents:
/usr/bin/ischroot:
/usr/bin/run-parts:
/usr/bin/savelog:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few of these executables are scripts. We need to figure out how we are going to link /bin/sh in #337 first

bins:
essential:
- debianutils_config
- libc6_libs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dash_bins can be added as a dependency here for the executables that are actually shell scripts.

essential:
- debianutils_bins
contents:
/usr/bin/which: {symlink: /usr/bin/which.debianutils}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/usr/bin/which.debianutils: should be in contents here so that this slice doesn't unnecessarily depend on unneeded binaries in bins slice.


config:
contents:
/usr/share/debianutils/shells:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file isn't necessary as a slice. However, this file is copied in the maintainer scripts to /etc/shells if that file doesn't exist, so please add a mutation script for that.

chroot "${rootfs}" /usr/bin/run-parts --list --regex 'shell$' /usr/sbin | tr '\n' ' ' | grep "/usr/sbin/add-shell /usr/sbin/remove-shell"

# run the update-shells to generate the shells file, this
# will output an error due to missing dpkg-realpath

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's this case, the package dpkg which contains dpkg-realpath should be a dependency of debianutils as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants