feat(24.04): add util-linux #330
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff of dependencies: slices/util-linux.yaml@@ -1,3 +1,5 @@
+base-files
+libaudit1
libblkid1
libc6
libcap-ng0 |
Meulengracht
force-pushed
the
slices/util-linux
branch
from
8e61ec5 to
cbaa976
Compare
Meulengracht
force-pushed
the
slices/util-linux
branch
from
cbaa976 to
f61b1cb
Compare
linostar
suggested changes
Sep 24, 2024
| - libtinfo6_libs | ||
| - libudev1_libs | ||
| - libuuid1_libs | ||
| - util-linux_generated |
There was a problem hiding this comment.
Suggested change
| - util-linux_generated | |
| - util-linux_generated | |
| - util-linux_pam-profile |
I believe su requires those files in pam-profile slice to run.
There was a problem hiding this comment.
Affirm, su does need those files.
| chroot "${rootfs}" lsipc | grep "MSGMNI" | ||
| chroot "${rootfs}" lsmem | grep "Total online memory" | ||
| chroot "${rootfs}" whereis lsblk | grep "/usr/bin/lsblk" | ||
|
|
There was a problem hiding this comment.
can you also add a test for su here to ensure that it is working properly?
rebornplusplus
requested changes
Oct 7, 2024
slices/util-linux.yaml
Outdated
| # the following emulates the post-install script | ||
| generated: | ||
| contents: | ||
| /usr/bin/pager: {symlink: /usr/bin/more} |
There was a problem hiding this comment.
nitpick 🙃
Suggested change
| /usr/bin/pager: {symlink: /usr/bin/more} | |
| /usr/bin/pager: {symlink: /bin/more} |
| - libtinfo6_libs | ||
| - libudev1_libs | ||
| - libuuid1_libs | ||
| - util-linux_generated |
There was a problem hiding this comment.
Affirm, su does need those files.
2 tasks
cjdcordeiro
requested changes
Oct 16, 2024
slices/util-linux.yaml
Outdated
| contents: | ||
| /usr/lib/mime/packages/util-linux: | ||
|
|
||
| pam-profile: |
There was a problem hiding this comment.
Suggested change
| pam-profile: | |
| pam-profiles: |
This commit adds a new slice su-support, which segregates the su and runuser binaries to that slice for granularity. It also modifies the tests a bit.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Proposing the util-linux package
Forward porting
Will open for 24.10 once this is approved.
Related issue
Closes #260
Checklist