Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(spread): add reusable workflow for Spread tests #280

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

cjdcordeiro
Copy link
Collaborator

@cjdcordeiro cjdcordeiro commented Jul 12, 2024

Proposed changes

This PR introduces a new reusable GitHub workflow for running Spread tests.

Each branch will have its own spread.yaml configuration, and this workflow will be called from the branches, on every PR.

The tests shall only run for:

  • the SDFs which are added or modified
  • the tests which are added or modified

Testing

Tested the execution of this workflow here:

Checklist

Copy link
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cris, it is looking very good! From the linked PRs I am missing the use case where the spread tests already exists and changing the SDF triggers the integration test (i.e. changed-slices triggering instead of changed-tests).

@cjdcordeiro
Copy link
Collaborator Author

Thanks Cris, it is looking very good! From the linked PRs I am missing the use case where the spread tests already exists and changing the SDF triggers the integration test (i.e. changed-slices triggering instead of changed-tests).

Thanks.

As for that use case, it's this one here: https://github.com/cjdcordeiro/chisel-releases/actions/runs/9905003363/job/27363593631?pr=11#step:8:27

From the logs you can see the SDF being considered as a trigger for that test. It just so happens that the test itself is also a trigger, cause it is also being created for the first time.

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Just one quick question about using less distinct actions.

.github/workflows/spread.yaml Show resolved Hide resolved
@cjdcordeiro cjdcordeiro merged commit 641b3c5 into canonical:main Jul 16, 2024
1 check passed
clay-lake pushed a commit to clay-lake/chisel-releases that referenced this pull request Nov 18, 2024
clay-lake pushed a commit to clay-lake/chisel-releases that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Look at me first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants