Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(22.04): add pkg-deps job #188

Merged

Conversation

rebornplusplus
Copy link
Member

Proposed changes

This PR adds a new pkg-deps job on Pull Request. It checks in changed files if slices of any package A has been listed in "essential" of a slice in package B, but B does not depend on A. If found, the CI will add a comment in the Pull Request with the findings.

Related issues/PRs

#187

Testing

See demo at rebornplusplus#9.

Checklist

This commit adds a new pkg-deps job on Pull Request. It checks in
changed files if slices of any package A has been listed in "essential"
of a slice in package B, but B does not depend on A. If found, the CI
will add a comment in the Pull Request with the findings.
@cjdcordeiro cjdcordeiro added the Priority Look at me first label Mar 12, 2024
@cjdcordeiro cjdcordeiro self-assigned this Mar 13, 2024
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple.

Copy link

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjdcordeiro cjdcordeiro merged commit ffa21b5 into canonical:ubuntu-22.04 Mar 13, 2024
@cjdcordeiro
Copy link
Collaborator

@rebornplusplus pls create the PRs for the remaining branches

gregory-schiano pushed a commit to gregory-schiano/chisel-releases that referenced this pull request Jun 22, 2024
This commit adds a new pkg-deps job on Pull Request. It checks in
changed files if slices of any package A has been listed in "essential"
of a slice in package B, but B does not depend on A. If found, the CI
will add a comment in the Pull Request with the findings.
cjdcordeiro pushed a commit to ozanmakes/chisel-releases that referenced this pull request Sep 27, 2024
This commit adds a new pkg-deps job on Pull Request. It checks in
changed files if slices of any package A has been listed in "essential"
of a slice in package B, but B does not depend on A. If found, the CI
will add a comment in the Pull Request with the findings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Look at me first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants