Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: zhijie-yang <[email protected]>
  • Loading branch information
cjdcordeiro and zhijie-yang authored Dec 18, 2024
1 parent bdf735d commit 8dfccc3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion slices/libpam-runtime.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ slices:
elif vals[0] == "Session-Interactive-Only":
if vals[1].strip() == "yes":
m = "session"
elif vals[0] in ["Auth-Initial", "Account-Initial", "Session-Initial", "Password-Initial"]:
elif vals[0] in ["Auth-Initial", "Account-Initial",

Check failure on line 74 in slices/libpam-runtime.yaml

View workflow job for this annotation

GitHub Actions / Lint / Lint

74:62 [trailing-spaces] trailing spaces
"Session-Initial", "Password-Initial"]:
d = []
for j in range(i + 1, len(lines)):
if ":" in lines[j]:
Expand Down
2 changes: 1 addition & 1 deletion tests/spread/integration/libpam-runtime/task.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ execute: |
# test that libpam correctly generated things
cat "$rootfs"/etc/pam.d/common-account | grep -E "account\s+\[success=1 new_authtok_reqd=done default=ignore\]\s+pam_unix\.so"
cat "$rootfs"/etc/pam.d/common-auth | grep -E "auth\s+\[success=1 default=ignore\]\s+pam_unix\.so\s+nullok"
cat "$rootfs"/etc/pam.d/common-password | grep -E "password\s+\[success=1 default=ignore\]\s+pam_unix\.so\s+obscure\s+use_authtok\s+try_first_pass\s+yescrypt"
cat "$rootfs"/etc/pam.d/common-password | grep -E "password\s+\[success=1 default=ignore\]\s+pam_unix\.so\s+obscure\s+yescrypt"
cat "$rootfs"/etc/pam.d/common-session | grep -E "session\s+\[default=1\]\s+pam_permit\.so"
cat "$rootfs"/etc/pam.d/common-session | grep -E "session\s+required\s+pam_unix\.so"
cat "$rootfs"/etc/pam.d/common-session-noninteractive | grep -E "session\s+\[default=1\]\s+pam_permit\.so"
Expand Down

0 comments on commit 8dfccc3

Please sign in to comment.