Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic integration testing #6

Merged
merged 5 commits into from
Nov 29, 2024
Merged

Conversation

reneradoi
Copy link
Collaborator

This PR adds a basic integration test to the etcd operator which:

  • deploys a cluster of three etcd nodes
  • checks the cluster's availability
  • checks if all deployed nodes where added as cluster members
  • writes test data to etcd
  • reads the test data

@reneradoi reneradoi marked this pull request as ready for review November 27, 2024 10:26
Copy link
Contributor

@skourta skourta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, René. This should get us started with the integration tests. I left enhancement comments but it already LGTM.

tests/integration/helpers.py Show resolved Hide resolved
tests/integration/helpers.py Show resolved Hide resolved
tests/integration/test_charm.py Show resolved Hide resolved
@reneradoi reneradoi merged commit 18b14d8 into main Nov 29, 2024
12 checks passed
@reneradoi reneradoi deleted the add-basic-integration-testing branch November 29, 2024 07:22
@reneradoi
Copy link
Collaborator Author

Thank you for your feedback. We can address the comments when we further enhance the tests. Of course we need to add more tests and more functionality to the testing suite. This PR here is just considered a basic coverage to get fast feedback when making changes to the code, and to give a starting point on how to create the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants