[DPE-5947] Scale up: add new units as etcd cluster members #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oting members when they are up-to-date with the leader
…ng etcd application
…oting members when they are up-to-date with the leader
…ng etcd application
reneradoi
commented
Jan 8, 2025
…' into add-new-units-as-cluster-members
…if tests are run on an already existing etcd application
skourta
previously approved these changes
Jan 9, 2025
reneradoi
dismissed
skourta’s stale review
The merge-base changed after approval.
Mehdi-Bendriss
requested changes
Jan 11, 2025
… accessing return values
…units-as-cluster-members # Conflicts: # charmcraft.yaml
Mehdi-Bendriss
approved these changes
Jan 15, 2025
skourta
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The etcd operator needs to integrate new juju units as members to the etcd cluster. Currently it waits on startup until all juju units have joined the peer relation and form an initial cluster. With this PR, this behaviour is changed to:
Please also see: https://github.com/canonical/charmed-etcd-operator/wiki/Scaling-up:-Workflow
This PR also adds integration testing for scaling up, including a continuous-writes-functionality (based on the one used in mongodb operator) to make sure the cluster is available for writing data during scaling operations.