Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加Champion Rankings数据 #123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

diaolingzc
Copy link

添加Champion Rankings数据
image

@cangzhang
Copy link
Owner

cangzhang commented Nov 30, 2021

This whole idea is good, thanks. But:

  1. op.gg is not always available for china mainland visitors, so this window may not work properly as expected.
  2. everything in this window is readonly, I don't think that makes sense.
  3. I don't think taking everything from op.gg (or other platforms) is a good thing. (maybe you can convince me about it.)

@diaolingzc
Copy link
Author

Regarding your three questions:

  1. the problem of op.gg access, I think it can be solved by data crawler, just like https://github.com/champ-r/data-crawler.
  2. Champion Rankings is essentially the statistical version of heroes. The nature of data aggregation itself is to let users know which heroes are the strongest in the current version.
  3. the method of data crawling can circumvent the project itself from obtaining data from op.gg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants