Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrono package #772

Merged
merged 26 commits into from
Dec 25, 2023
Merged

Chrono package #772

merged 26 commits into from
Dec 25, 2023

Conversation

skyz1
Copy link
Collaborator

@skyz1 skyz1 commented Oct 25, 2023

Closes: #732

This PR adds a basic Chrono package that supports:

  1. Instants
  2. Accessing the System Time
  3. Durations

Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@skyz1 skyz1 requested a review from JonasWanke October 25, 2023 12:14
@skyz1 skyz1 self-assigned this Oct 25, 2023
@jwbot jwbot added P: Core Package: Candy's standard library P: Compiler: VM Package: The VM executing Candy byte code (LIR) P: Examples Package: Examples labels Oct 25, 2023
@jwbot jwbot enabled auto-merge October 25, 2023 12:14
JonasWanke
JonasWanke requested changes Nov 2, 2023
View reviewed changes
packages/Chrono/clock.candy Outdated Show resolved Hide resolved
packages/Chrono/duration.candy Outdated Show resolved Hide resolved
packages/Chrono/duration.candy Outdated Show resolved Hide resolved
packages/Chrono/duration.candy Outdated Show resolved Hide resolved
packages/Chrono/instant.candy Outdated Show resolved Hide resolved
packages/Chrono/instant.candy Outdated Show resolved Hide resolved
packages/Chrono/instant.candy Outdated Show resolved Hide resolved
packages/Core/text.candy Outdated Show resolved Hide resolved
packages/Core/text.candy Outdated Show resolved Hide resolved
packages/Examples/clock.candy Outdated Show resolved Hide resolved
@skyz1 skyz1 requested a review from JonasWanke November 29, 2023 18:41
@jwbot
Copy link
Collaborator

jwbot commented Nov 29, 2023

The golden IRs have changed: cca5a40..6c0dffd

@skyz1
Copy link
Collaborator Author

skyz1 commented Dec 16, 2023

@JonasWanke Sorry for the delay, I've been very busy lately. I have addressed your remaining comments.

@jwbot
Copy link
Collaborator

jwbot commented Dec 16, 2023

The golden IRs have changed: cfce928..7e7c4bc

@jwbot
Copy link
Collaborator

jwbot commented Dec 19, 2023

The golden IRs have changed: 648991e..93195eb

JonasWanke
JonasWanke requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@JonasWanke JonasWanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one bug, but the rest looks good

packages/Chrono/instant.candy Outdated Show resolved Hide resolved
@skyz1 @JonasWanke
Fix type mistake
b8c127d 
Co-authored-by: Jonas Wanke <[email protected]>
@skyz1 skyz1 requested a review from JonasWanke December 25, 2023 15:14
@jwbot
Copy link
Collaborator

jwbot commented Dec 25, 2023

The golden IRs have changed: 648991e..7eec21b

@jwbot jwbot merged commit d36e515 into main Dec 25, 2023
11 checks passed
@jwbot jwbot deleted the chrono-package branch December 25, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasWanke JonasWanke JonasWanke approved these changes

Assignees

@skyz1 skyz1

Labels
P: Compiler: VM Package: The VM executing Candy byte code (LIR) P: Core Package: Candy's standard library P: Examples Package: Examples
Projects
🍭 Candy
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chrono Package
3 participants
@skyz1 @jwbot @JonasWanke