Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor text improvements #1021

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Minor text improvements #1021

wants to merge 5 commits into from

Conversation

JonasWanke
Copy link
Member

Removes a workaround for #896, improves code readability, and reduces clones

Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@JonasWanke JonasWanke added T: Refactor Type: Refactoring T: Performance Type: Performance Improvements labels Apr 18, 2024
@JonasWanke JonasWanke requested a review from MarcelGarus April 18, 2024 12:13
@jwbot jwbot enabled auto-merge April 18, 2024 12:14
@jwbot jwbot added P: Compiler: Frontend Package: The compiler frontend P: Csv Package: CSV P: AnsiEscapeSequences Package: Low-level ANSI Escape Sequences labels Apr 18, 2024
@jwbot
Copy link
Collaborator

jwbot commented Apr 18, 2024

🐰Bencher

ReportThu, April 18, 2024 at 12:24:08 UTC
ProjectCandy
Branchminor-text-improvements
TestbedGitHub Actions: Ubuntu 22.04
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles
InstructionsInstructions Results
instructions
L1 AccessesL1 Accesses Results
accesses
L2 AccessesL2 Accesses Results
accesses
RAM AccessesRAM Accesses Results
accesses
Total AccessesTotal Accesses Results
total-accesses
compile: Examples/fibonacci.candy ➖ (view plot)1792856627.000➖ (view plot)1191617039.000➖ (view plot)1621037427.000➖ (view plot)10704904.000➖ (view plot)3379848.000➖ (view plot)1635122179.000
compile: Examples/helloWorld.candy ➖ (view plot)284102903.000➖ (view plot)176240373.000➖ (view plot)248110668.000➖ (view plot)1452945.000➖ (view plot)820786.000➖ (view plot)250384399.000
vm_runtime: Examples/fibonacci.candy 10➖ (view plot)181400551.000➖ (view plot)106034494.000➖ (view plot)149349651.000➖ (view plot)794213.000➖ (view plot)802281.000➖ (view plot)150946145.000
vm_runtime: Examples/helloWorld.candy ➖ (view plot)154524197.000➖ (view plot)88646939.000➖ (view plot)124972047.000➖ (view plot)700365.000➖ (view plot)744295.000➖ (view plot)126416707.000

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: AnsiEscapeSequences Package: Low-level ANSI Escape Sequences P: Compiler: Frontend Package: The compiler frontend P: Csv Package: CSV T: Performance Type: Performance Improvements T: Refactor Type: Refactoring
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants