Implement zeebe moddle extension and canCopyProperty #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
requested changes
Nov 12, 2020
MaxTru
requested changes
Nov 13, 2020
There was a problem hiding this comment.
Also:
- please format commit message in active tense (see history of commit messages for examples). Might be something like "fix(replace): add moddle extension for canCopyProperty"
- Clarfication question for me: how do we approach all the zeebe moddle configurations for other properties (aside from Input Output)? Will we create separate tickets or do all of this in a one-time exercise?
azeghers
force-pushed
the
248-zeebe-extension
branch
2 times, most recently
from
8b6edc8 to
e706d5d
Compare
barmac
reviewed
Nov 13, 2020
lib/extension.js
Outdated
| */ | ||
| ZeebeModdleExtension.prototype.canCopyProperty = function(property, parent) { | ||
|
|
||
| // check wether property is allowed in parent |
There was a problem hiding this comment.
Suggested change
| // check wether property is allowed in parent | |
| // check if property is allowed in parent |
azeghers
force-pushed
the
248-zeebe-extension
branch
from
e706d5d to
32af48f
Compare
|
As Nico mentioned, we need readme update in this PR as well.
This can be based on camunda/camunda-bpmn-moddle readme. |
azeghers
force-pushed
the
248-zeebe-extension
branch
from
32af48f to
668df8a
Compare
|
Further schema extensions to be made using #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to zeebe-io/zeebe-modeler#248