Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable secrets rule #84

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Disable secrets rule #84

merged 3 commits into from
Sep 8, 2023

Conversation

philippfromme
Copy link
Collaborator

@philippfromme philippfromme commented Sep 8, 2023 •
edited
Loading

  • update to [email protected]
  • adjust secrets warning message
  • secrets rule disabled for now
  • adjust no-loop error message

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 8, 2023
@philippfromme philippfromme requested a review from barmac September 8, 2023 13:19
@barmac
Copy link
Contributor

barmac commented Sep 8, 2023 •
edited
Loading

Let's also note that secrets rule is disabled in the title.

@barmac barmac changed the title Secrets error to warn Disable secrets rule Sep 8, 2023
@merge-me merge-me bot merged commit 2c73088 into main Sep 8, 2023
2 checks passed
@merge-me merge-me bot deleted the secrets-error-to-warn branch September 8, 2023 13:23
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippfromme @barmac