Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support compensation #103

Merged
merged 1 commit into from
Mar 22, 2024
Merged

feat: support compensation #103

merged 1 commit into from
Mar 22, 2024

Conversation

barmac
Copy link
Contributor

@barmac barmac commented Mar 22, 2024

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Mar 22, 2024
@barmac barmac force-pushed the 8-5-compensation-support branch from e5055f0 to 1c5ab36 Compare March 22, 2024 13:33
@barmac barmac marked this pull request as ready for review March 22, 2024 13:33
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 22, 2024
@barmac barmac requested review from a team, philippfromme and marstamm and removed request for a team March 22, 2024 13:34
@barmac barmac mentioned this pull request Mar 22, 2024
Closed
3 tasks
@barmac barmac requested a review from nikku March 22, 2024 13:45
nikku
nikku approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm.

My only remark is: Why do we allow editing of wait for completion for C8 in the first place, if it must be checked?

image

@merge-me merge-me bot merged commit 759c295 into main Mar 22, 2024
3 checks passed
@merge-me merge-me bot deleted the 8-5-compensation-support branch March 22, 2024 13:50
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 22, 2024
@barmac
Copy link
Contributor Author

barmac commented Mar 22, 2024

We could remove it from the properties panel, but how would you then fix a diagram that you brought from another tool? It's a BPMN property.

@nikku
Copy link
Member

nikku commented Mar 22, 2024

👍 for not removing it (for the reason you mentioned).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from camunda/modeling-dev

@marstamm marstamm Awaiting requested review from marstamm marstamm was automatically assigned from camunda/modeling-dev

Assignees

@barmac barmac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barmac @nikku