Skip to content

Commit

Permalink
feat: update terminology to "camunda user task"
Browse files Browse the repository at this point in the history
Related to #4749
  • Loading branch information
Skaiir committed Dec 11, 2024
1 parent ba011a4 commit 1826b68
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions lib/utils/error-messages.js
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ function getExtensionElementNotAllowedErrorMessage(report, executionPlatform, ex
}

if (is(extensionElement, 'zeebe:UserTask')) {
return getSupportedMessage('A <User Task> with <Implementation: Zeebe user task>', executionPlatform, executionPlatformVersion, allowedVersion);
return getSupportedMessage('A <User Task> with <Implementation: Camunda user task>', executionPlatform, executionPlatformVersion, allowedVersion);
}

if (is(node, 'bpmn:ScriptTask') && is(extensionElement, 'zeebe:Script')) {
Expand Down Expand Up @@ -390,7 +390,7 @@ function getExtensionElementRequiredErrorMessage(report, executionPlatform, exec
}

if (requiredExtensionElement === 'zeebe:UserTask') {
return `${ getIndefiniteArticle(typeString) } <${ typeString }> with <Implementation: Job worker> is deprecated on ${ getExecutionPlatformLabel(executionPlatform, executionPlatformVersion) }. Consider migrating to <Implementation: Zeebe user task>.`;
return `${ getIndefiniteArticle(typeString) } <${ typeString }> with <Implementation: Job worker> is deprecated on ${ getExecutionPlatformLabel(executionPlatform, executionPlatformVersion) }. Consider migrating to <Implementation: Camunda user task>.`;
}

return message;
Expand Down Expand Up @@ -570,7 +570,7 @@ function getPropertyRequiredErrorMessage(report, executionPlatform, executionPla
return `${ getIndefiniteArticle(typeString) } <${ typeString }> with <Form type: Custom form key> must have a defined <Form key>`;
}

// Zeebe User Task
// Camunda User Task
if (is(node, 'zeebe:FormDefinition') && isZeebeUserTask(parentNode)) {
if (isEmptyString(node.get('externalReference'))) {
return `${ getIndefiniteArticle(typeString) } <${ typeString }> with <Form type: External reference> must have a defined <External reference>`;
Expand Down
8 changes: 4 additions & 4 deletions test/spec/utils/error-messages.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ describe('utils/error-messages', function() {
const errorMessage = getErrorMessage(report, 'Camunda Cloud', executionPlatformVersion);

// then
expect(errorMessage).to.equal('A <User Task> with <Implementation: Zeebe user task> is only supported by Camunda 8.5 or newer');
expect(errorMessage).to.equal('A <User Task> with <Implementation: Camunda user task> is only supported by Camunda 8.5 or newer');
});


Expand Down Expand Up @@ -701,7 +701,7 @@ describe('utils/error-messages', function() {
const errorMessage = getErrorMessage(report, 'Camunda Cloud', executionPlatformVersion);

// then
expect(errorMessage).to.equal('A User Task with <Implementation: Job worker> is deprecated on Camunda 8.6. Consider migrating to <Implementation: Zeebe user task>.');
expect(errorMessage).to.equal('A User Task with <Implementation: Job worker> is deprecated on Camunda 8.6. Consider migrating to <Implementation: Camunda user task>.');
});

});
Expand Down Expand Up @@ -1395,7 +1395,7 @@ describe('utils/error-messages', function() {
});


it('should adjust (Zeebe User Task) (form ID) (Camunda 8.5 and newer)', async function() {
it('should adjust (Camunda User Task) (form ID) (Camunda 8.5 and newer)', async function() {

// given
const node = createElement('bpmn:UserTask', {
Expand Down Expand Up @@ -1459,7 +1459,7 @@ describe('utils/error-messages', function() {
});


it('should adjust (Zeebe User Task) (external reference) (Camunda 8.5 and newer)', async function() {
it('should adjust (Camunda User Task) (external reference) (Camunda 8.5 and newer)', async function() {

// given
const node = createElement('bpmn:UserTask', {
Expand Down
4 changes: 2 additions & 2 deletions test/spec/utils/properties-panel.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,7 @@ describe('utils/properties-panel', function() {
});


it('user-task-form (Zeebe User Task) - Form ID (Camunda 8.5 and newer)', async function() {
it('user-task-form (Camunda User Task) - Form ID (Camunda 8.5 and newer)', async function() {

// given
const node = createElement('bpmn:UserTask', {
Expand Down Expand Up @@ -928,7 +928,7 @@ describe('utils/properties-panel', function() {
});


it('user-task-form (Zeebe User Task) - External reference (Camunda 8.5 and newer)', async function() {
it('user-task-form (Camunda User Task) - External reference (Camunda 8.5 and newer)', async function() {

// given
const node = createElement('bpmn:UserTask', {
Expand Down

0 comments on commit 1826b68

Please sign in to comment.