Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gemini): implement Google Gemini connector #3549

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DenovVasil
Copy link
Contributor

@DenovVasil DenovVasil commented Oct 29, 2024

Description

Implement gemini connector

image

Related issue

closes
#3717

@DenovVasil DenovVasil requested a review from a team as a code owner October 29, 2024 08:14
@DenovVasil DenovVasil marked this pull request as draft October 29, 2024 08:15
@DenovVasil DenovVasil self-assigned this Oct 29, 2024
@DenovVasil DenovVasil force-pushed the 2543-google-gemini-impl-connector branch from 430882f to e88017f Compare October 30, 2024 09:54
@DenovVasil DenovVasil added this to the 8.7.0-alpha2 milestone Oct 30, 2024
@DenovVasil DenovVasil changed the title 2543 google gemini impl connector feat(gemini ): impl connector Oct 30, 2024
@github-actions github-actions bot temporarily deployed to connectors-2543-google-gem-c8sm November 1, 2024 13:48 Destroyed
@DenovVasil DenovVasil force-pushed the 2543-google-gemini-impl-connector branch from e88017f to 3b4ed0a Compare November 13, 2024 23:43
@github-actions github-actions bot temporarily deployed to connectors-2543-google-gem-c8sm November 13, 2024 23:44 Destroyed
@DenovVasil DenovVasil force-pushed the 2543-google-gemini-impl-connector branch from 3b4ed0a to 7a9bcff Compare November 13, 2024 23:55
@github-actions github-actions bot temporarily deployed to connectors-2543-google-gem-c8sm November 13, 2024 23:55 Destroyed
@DenovVasil DenovVasil force-pushed the 2543-google-gemini-impl-connector branch from 7a9bcff to d1f2197 Compare November 18, 2024 08:11
@github-actions github-actions bot temporarily deployed to connectors-2543-google-gem-c8sm November 18, 2024 08:11 Destroyed
@DenovVasil DenovVasil force-pushed the 2543-google-gemini-impl-connector branch from d1f2197 to f74d3cf Compare November 20, 2024 22:35
@github-actions github-actions bot temporarily deployed to connectors-2543-google-gem-c8sm November 20, 2024 22:35 Destroyed
@DenovVasil DenovVasil force-pushed the 2543-google-gemini-impl-connector branch from f74d3cf to ac96f8d Compare November 20, 2024 22:51
.toArray();
}

private Object map2MediaOrText(Map<String, String> map) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by the way, about methods namings : a few links to naming conventions : https://www.oracle.com/java/technologies/javase/codeconventions-namingconventions.html , https://google.github.io/styleguide/javaguide.html#s5-naming , but in this case, up to you and connector teams

@DenovVasil DenovVasil force-pushed the 2543-google-gemini-impl-connector branch 5 times, most recently from 5e06bdd to 604fa3c Compare November 26, 2024 08:31
@Oleksiivanov Oleksiivanov changed the title feat(gemini ): impl connector feat(gemini): implement Google Gemini connector Nov 26, 2024
@DenovVasil DenovVasil force-pushed the 2543-google-gemini-impl-connector branch from 604fa3c to b0c1791 Compare November 26, 2024 09:07
@Oleksiivanov Oleksiivanov linked an issue Nov 26, 2024 that may be closed by this pull request
@DenovVasil DenovVasil force-pushed the 2543-google-gemini-impl-connector branch 3 times, most recently from 53beaa4 to 4356f98 Compare November 26, 2024 22:03
@DenovVasil DenovVasil force-pushed the 2543-google-gemini-impl-connector branch from 4356f98 to e4dcc07 Compare November 27, 2024 11:04
Copy link
Contributor

@Oleksiivanov Oleksiivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but don’t merge it until the main reviewers from the connector team approve.

@DenovVasil DenovVasil marked this pull request as ready for review November 27, 2024 11:23
@DenovVasil DenovVasil added the qa:required Will trigger the QA workflow label Nov 28, 2024
@johnBgood
Copy link
Collaborator

johnBgood commented Nov 28, 2024

QA information

Test Environment

  • Environment:
    • SaaS only
    • SM only
    • Both
  • Connectors version: <TO_BE_REPLACED>

Test Scope

Please describe the test scope, happy path, edge cases that come to your mind, and whatever you think might relevant to test

Test Data

Please provide the test data, if needed (files, URLs, code snippets, FEEL expressions)

@github-actions github-actions bot temporarily deployed to connectors-2543-google-gem-c8sm November 28, 2024 15:48 Destroyed
@github-actions github-actions bot temporarily deployed to connectors-2543-google-gem-c8sm November 28, 2024 16:03 Destroyed
@DenovVasil DenovVasil force-pushed the 2543-google-gemini-impl-connector branch from e4dcc07 to 77bee8a Compare November 28, 2024 16:48
@github-actions github-actions bot temporarily deployed to connectors-2543-google-gem-c8sm November 28, 2024 16:48 Destroyed
@github-actions github-actions bot temporarily deployed to connectors-2543-google-gem-c8sm November 28, 2024 22:49 Destroyed
@github-actions github-actions bot had a problem deploying to connectors-2543-google-gem-c8sm November 29, 2024 12:21 Failure
Copy link
Contributor

🚀 Deployment Results 🚀

Please find below the results of the latest deployments.

connectors-2543-google-gem-c8sm

🔧 Troubleshooting 🔧

The 🔗 ArgoCD link can be used to check the state and configuration of all the services deployed as part of the preview environments and get logs.

In case of error, please check 📋 Deployment Jobs and 🔗 ArgoCD to debug, and check our (yet to come) troubleshooting page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-preview qa:required Will trigger the QA workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Google Gemini connector
3 participants