Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update form dependencies #4092

Merged
merged 3 commits into from
Feb 2, 2024
Merged

deps: update form dependencies #4092

merged 3 commits into from
Feb 2, 2024

Conversation

vsgoulart
Copy link
Contributor

@vsgoulart vsgoulart commented Feb 1, 2024

Updates

Some highlights

  • FEAT: implement HTML component and cleanup Text component (#999)
  • FIX: resize textarea on input changes (#1011)
  • FIX: prevent demo data from being created on edited tables (#1005)

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 1, 2024
@nikku
Copy link
Member

nikku commented Feb 2, 2024

Thanks for the PR @vsgoulart! I'll add the highlights to the CHANGELOG.

@nikku
Copy link
Member

nikku commented Feb 2, 2024

Added forms changes via a3d5411.

@nikku
Copy link
Member

nikku commented Feb 2, 2024

I found one issue that we may want to address:

  • We moved the popup editor toggle to the top of the line. This is something we may want to follow-up with in forms HTML editor, too:

    capture CwIl7H_optimized

    Generally speaking we don't hide contents and hence also don't scroll horizontally:

    capture XKEIrB_optimized

    But I recon that this field is somewhat special, as the HTML can be arbitrary (and huge). I understand why you decided to go this way. Let's align the toggle and we should be good.

@nikku nikku merged commit db1c597 into develop Feb 2, 2024
11 of 12 checks passed
@nikku nikku deleted the bump-form-deps branch February 2, 2024 10:02
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants