-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs about sdk client configuration options #4826
Conversation
👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉 You can read more about the versioning within our docs in our documentation guidelines. |
### Request timeout | ||
#### Max metadata size | ||
|
||
A custom maxMetadataSize @TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A custom maxMetadataSize
allows the client to receive larger or smaller response headers from Camunda.
### Default task type | ||
#### Deployment | ||
|
||
@TODO not sure if this is used ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems not used, so we can remove it
@nicpuppa I added your suggestions and copied the updates to the 8.6 folder. I guess the PR is then ready to go or do you think something is missing? I would also like to learn how to merge & deploy, thus should we do that together on moday? |
Hi @eppdot, I added the tech writers group to review your PR. We usually handle the merge and deploy based on how you respond to the PR template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eppdot Approved, great work, just a few rewording suggestions/typos. but non-blocking 👍 🚀
Co-authored-by: Mark Sellings <[email protected]>
351a105
to
aca0441
Compare
@mesellings Thanks a lot for reviewing 🚀 I just took over all your suggestions. As is this my first PR here, can you explain to me what the next steps are? Cheers, Stephan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - nice job! 🚀
@eppdot Hi, great job for your first docs PR!
Tip: Use the Description check boxes and labels to let us know when it needs to be released, to save us having to ask you - makes it easier for everyone to see when the PR needs to go out, and if it belongs to a release. |
@eppdot I will be doing a docs release today/tomorrow, so I merged it for you, and it will get included in this release 👍 |
🧹 Preview environment for this PR has been torn down. |
Description
closes 26700
Synced the spring sdk configuration docs with the actual property classes in code.
In general I just added the missing properties and re-organized a bit the structure.
There are a few open TODOs, that we need to check
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).