-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document user task listeners for user task modeling #4814
Conversation
👋 🤖 🤔 Hello, @ce-dmelnych! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a technical perspective, this is very clean writing! Nice work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
🔧 I have a few small suggestions though
89a871f
to
e60a7b0
Compare
c3474cb
to
c42b539
Compare
The base branch was changed.
Scope: - added subsection on how to define user task listeners. - linked with the `User task listeners` concept page. - provided an XML example for the user task with the defined user task listeners. Co-authored-by: Ana Vinogradova <[email protected]>
- making user task listeners description language agnostic - using `attributes` instead of `properties` in configuration
c42b539
to
d251804
Compare
Description
Scope:
User task listeners
concept page.These changes were made together by @ana-vinogradova-camunda and @ce-dmelnych so they don't require additional Engineering review. A Technical writer review is appreciated.
closes camunda/camunda#26343
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).