-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nodejs sdk to overview page #4784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm 👍 🚀
One non-blocking issue that perhaps is just something to look at when we move to docusaurus 3 is that the card height is dependent on the text content - here the node card is now taller than the one next to it:
I would expect card components to behave slightly differently ideally, but I guess our options are:
- Adjust the meta description for the node.js page, i.e. remove ", available via npm.", except this then conflicts with SEO description length.
- Leave as is, take a look at card components in Docusaurus 3.
I guess we shouldn't be trying to fit content to a responsive layout, so I think 2 is our best option, but up to you - just something I noticed?
@mesellings Good catch. This was bothering me so for the time being I adjusted the description length, as it isn't dire either way. Cheers to Doc3 when this perhaps won't be an issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm 👍 🚀
🧹 Preview environment for this PR has been torn down. |
Description
Closes #4782.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).