Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove OpenSearch warnings #4750

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Conversation

grlimacan
Copy link
Contributor

@grlimacan grlimacan commented Dec 11, 2024

Description

Now that OpenSearch is fully supported in Optimize with 8.7 / 3.15, we need to remove the warnings for the latest release. Note that the warnings still apply for 8.6 / 3.14 and below, therefore mostly only updating the most current docs

related to camunda/camunda#23615
camunda/camunda#23766

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@grlimacan grlimacan self-assigned this Dec 11, 2024
@grlimacan grlimacan added the 8.7.0-alpha3 January 2024 alpha release label Dec 11, 2024
Copy link
Contributor

👋 🤖 🤔 Hello, @grlimacan! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.

  • docs/self-managed/operational-guides/backup-restore/optimize-backup.md
These files were changed only in optimize/. You might want to duplicate these changes in optimize_versioned_docs/version-3.14.0/.
  • optimize/self-managed/optimize-deployment/configuration/shared-elasticsearch-cluster.md
  • optimize/self-managed/optimize-deployment/configuration/system-configuration-platform-7.md
  • optimize/self-managed/optimize-deployment/configuration/system-configuration.md
  • optimize/self-managed/optimize-deployment/install-and-start.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@grlimacan grlimacan force-pushed the optimize-23615-remove-os-warnings branch from 838386c to b13be7a Compare December 11, 2024 14:21
@PHWaechtler PHWaechtler self-requested a review December 11, 2024 14:25
@github-actions github-actions bot temporarily deployed to camunda-docs December 11, 2024 14:34 Destroyed
Copy link
Contributor

@PHWaechtler PHWaechtler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning removal lgtm, just got some small suggestions and leftover Elasticsearch mentions, though let me know if we're deliberately not changing all of them, unsure what the current state here is.

PHWaechtler
PHWaechtler previously approved these changes Dec 11, 2024
Copy link
Contributor

@PHWaechtler PHWaechtler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm just that one indentation change needs undone 👍 👍

@github-actions github-actions bot temporarily deployed to camunda-docs December 11, 2024 15:21 Destroyed
@grlimacan grlimacan requested review from PHWaechtler, a team and mboskamp December 11, 2024 15:32
@github-actions github-actions bot temporarily deployed to camunda-docs December 11, 2024 15:44 Destroyed
@grlimacan grlimacan merged commit 9640251 into main Dec 12, 2024
12 checks passed
@grlimacan grlimacan deleted the optimize-23615-remove-os-warnings branch December 12, 2024 06:56
Copy link
Contributor

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.7.0-alpha3 January 2024 alpha release deploy Stand up a temporary docs site with this PR
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants