Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More explicit description how to apply the DNS changes #4747

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

ingorichtsmeier
Copy link
Contributor

Description

Clarify the change DNS procedure for the AWS dual region setup.

I stumbled about this when setting up my own dual region cluster. The description how to apply the changes was hidden in the output of the script.

It's not everybody favor to do inline Kubernetes object editing using VI, so I added an alternative with editiing the files locally and ally them with kubectl afterwards.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Langleu
Langleu previously approved these changes Dec 11, 2024
Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition 🚀.
Looks good from my side as an alternative approach.

@pepopowitz pepopowitz requested review from a team and removed request for pepopowitz December 11, 2024 15:54
@ingorichtsmeier
Copy link
Contributor Author

Thank you, @conceptualshark, for improving my language.

Could you please take over to merge and publish with one of the next docs release?

It looks like a single button to push, But I don't know if you need any more labels or other actions behind the scene.

@mesellings mesellings added component:docs Documentation improvements, including new or updated content component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed labels Dec 12, 2024
@mesellings mesellings merged commit ccdafa9 into main Dec 12, 2024
8 checks passed
@mesellings mesellings deleted the apply-dns-changes-to-dual-region-aws-cluster branch December 12, 2024 09:53
@mesellings
Copy link
Contributor

Merged for you, will be released in the next docs release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants