Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(play): add scenarios section #4737

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

docs(play): add scenarios section #4737

wants to merge 7 commits into from

Conversation

huygur
Copy link
Contributor

@huygur huygur commented Dec 10, 2024

Description

related to https://github.com/camunda/play/issues/744

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Copy link
Contributor

github-actions bot commented Dec 10, 2024

👋 🤖 🤔 Hello, @mesellings! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.

  • docs/components/modeler/web-modeler/img/play-cluster-configuration.png
  • docs/components/modeler/web-modeler/img/play-coverage.png
  • docs/components/modeler/web-modeler/img/play-definition.png
  • docs/components/modeler/web-modeler/img/play-example-data.png
  • docs/components/modeler/web-modeler/img/play-instance.png
  • docs/components/modeler/web-modeler/img/play-modifications.png
  • docs/components/modeler/web-modeler/img/play-rewind.png
  • docs/components/modeler/web-modeler/img/play-save-scenario.png
  • docs/components/modeler/web-modeler/img/play-scenario-runs.png
  • docs/components/modeler/web-modeler/play-your-process.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@huygur huygur marked this pull request as ready for review December 10, 2024 08:43
@huygur huygur requested review from HanselIdes and a team December 10, 2024 08:43
@mesellings
Copy link
Contributor

@huygur Which alpha/minor is this for please?

@huygur huygur added the 8.7.0-alpha3 January 2024 alpha release label Dec 10, 2024
@huygur
Copy link
Contributor Author

huygur commented Dec 10, 2024

@huygur Which alpha/minor is this for please?

@mesellings sorry I forgot to add the label 🤦‍♀️ it's there now

- Scenarios are stored in the browser's local storage, making them accessible only in the current browser and not usable outside of Play or in a different browser.
- Call activities are not supported; therefore, scenarios containing them cannot be executed successfully.
- Scenario paths that include process modifications are not supported.
- Similar to process instances, scenarios do not run in isolation. For instance, if two scenario paths are defined for a process and both contain the same message event or signal event, running these scenarios simultaneously may lead to unintended consequences. Publishing a scenario or broadcasting a signal could inadvertently impact the other scenario, resulting in the failure of both.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 It could be nice to include a link to the documentation for the nature of message events and signal events, where the issue with global publish/broadcast is mentioned. However, I am not aware of such a link at this moment.

Copy link
Contributor

@HanselIdes HanselIdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions

docs/components/modeler/web-modeler/play-your-process.md Outdated Show resolved Hide resolved

- Scenarios are stored in the browser's local storage, making them accessible only in the current browser and not usable outside of Play or in a different browser.
- Call activities are not supported; therefore, scenarios containing them cannot be executed successfully.
- Scenario paths that include process modifications are not supported.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable changes are actually supported
scenarios cover everything rewind feature does

@@ -92,6 +92,38 @@ Play's rewind operation currently does not support the following elements:
- Play rewinds to an element, not to an element instance. For example, if you wanted to rewind your process to a sequential multi-instance service task which ran five times, it will rewind your process to the first instance of that service task.
- Play rewinds processes by initiating a new instance and executing each element. However, if any element behaves differently from the previous execution, such as a Connector returning a different result, the rewind may fail.

## Scenarios

You can validate your process by creating scenarios for different paths, ensuring that it continues to function as expected after any changes to your diagram. Scenarios let you replay and confirm that the process completes correctly with the pre-defined actions and variables.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can validate your process by creating scenarios for different paths, ensuring that it continues to function as expected after any changes to your diagram. Scenarios let you replay and confirm that the process completes correctly with the pre-defined actions and variables.
Scenarios accelerate manual testing by providing a no-code way of quickly re-running processes while tracking your test coverage.
You can validate your process by creating and rerunning scenarios for different paths, ensuring that it continues to function as expected after any changes to your diagram. Scenarios let you replay and confirm that the process completes correctly with the pre-defined actions and variables. Although scenarios are quick to develop and use for non-developers, our [best practices](https://docs.camunda.io/docs/next/components/best-practices/development/testing-process-definitions/) suggest using specialized test libraries in your CI/CD pipeline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied your suggestion 👍
I am not sure though, if we should call this a 'test coverage'. But I have no better suggestion 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, me neither. I'm framing the value around accelerating manual testing


- Scenarios are stored in the browser's local storage, making them accessible only in the current browser and not usable outside of Play or in a different browser.
- Call activities are not supported; therefore, scenarios containing them cannot be executed successfully.
- Scenario paths that include process modifications are not supported.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable changes are actually supported
scenarios cover everything rewind feature does


Scenarios accelerate manual testing by providing a no-code way of quickly re-running processes while tracking your test coverage.

You can validate your process by creating and rerunning scenarios for different paths, ensuring that it continues to function as expected after any changes to your diagram. Scenarios let you replay and confirm that the process completes correctly with the pre-defined actions and variables. Although scenarios are quick to develop and use for non-developers, our [best practices](https://docs.camunda.io/docs/next/components/best-practices/development/testing-process-definitions/) suggest using specialized test libraries in your CI/CD pipeline.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[all.hrefProduction] Improper link format: 'best practices'. Please use relative URLs.

@mesellings mesellings requested review from mesellings and removed request for a team December 12, 2024 12:34
@mesellings mesellings added kind/feature Issues related with features to be documented component:modeler Issues related with Modeler project hold This issue is parked, do not merge. labels Dec 12, 2024
@HanselIdes HanselIdes self-requested a review December 18, 2024 11:07
HanselIdes
HanselIdes previously approved these changes Dec 18, 2024
Copy link
Contributor

@HanselIdes HanselIdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍 🚀 I made some changes directly for rewording, structure, formatting etc - great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.7.0-alpha3 January 2024 alpha release component:modeler Issues related with Modeler project hold This issue is parked, do not merge. kind/feature Issues related with features to be documented
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

3 participants