Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(priority-election): fix the property key #4716

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

diasonti
Copy link
Contributor

@diasonti diasonti commented Dec 5, 2024

Description

Fixed property key in the Priority Election section of Zeebe self-hosted docs, along with some minor grammar mistakes.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2024

CLA assistant check
All committers have signed the CLA.

@akeller akeller requested a review from a team December 5, 2024 15:37
@akeller akeller added component:zeebe Issues related with Zeebe project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed labels Dec 5, 2024
@akeller
Copy link
Member

akeller commented Dec 5, 2024

@diasonti thank you for signing out CLA! I've added our tech writers to review and will pull in a member of the Zeebe team as well. Thank you for your PR.

Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch with the config key 👍

@akeller
Copy link
Member

akeller commented Dec 5, 2024

Quick summary and link to the thread internally - depending on how the context handles double quotes, including them could make it part of the value (meaning instead of true the value is "true". There might be a context where you need double quotes.

@akeller akeller merged commit 24286f3 into camunda:main Dec 5, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed component:zeebe Issues related with Zeebe project
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants