Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify string value in spring guide #4692

Closed
wants to merge 1 commit into from
Closed

Conversation

christinaausley
Copy link
Contributor

Description

@pepopowitz Am I correct that you need to write "charge-credit-card" in quotation marks, otherwise it is not interpreted as string by the feel engine and leads to an exception? This could help clarify for beginners.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@christinaausley christinaausley added the component:docs Documentation improvements, including new or updated content label Dec 2, 2024
@christinaausley christinaausley self-assigned this Dec 2, 2024
@pepopowitz
Copy link
Collaborator

Am I correct that you need to write "charge-credit-card" in quotation marks, otherwise it is not interpreted as string by the feel engine and leads to an exception?

No, I don't believe this is true. The service task name should not contain quotation marks.

You mention FEEL though, and this makes me wonder if you're referring to a different step? The steps you edited are specifying the name of a service task, and I don't believe run through the FEEL engine.

@christinaausley
Copy link
Contributor Author

I see what I did wrong here @pepopowitz -- closing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants