-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge clients sdks #4657
Merge clients sdks #4657
Conversation
@aleksander-dytko @akeller I think this is also an opportunity to talk about what we want to do with community clients, but I have a few questions before I can strongly recommend one action over another: How attached are our users to the community clients? While every user matters, if this is no longer fully supported we are almost keeping these community clients around in the sidebar as a disservice. For example, Ballerina and Delphi last had changes two years ago., EJB and Ruby almost a year ago, etc. If we do have a large number of users who still use the community clients, we could find a new placement, but I'm not sure this is the case. If we decide to remove these, I would recommend removing them in |
@christinaausley, great questions all around.
My understanding is they are widely used by customers, though I'm not exactly sure and I'd have to find data to support that (maybe asking our consultants?). My perception comes from knowing about support tickets and other feedback around community-supported clients. Are you asking because of the API changes which will make the current versions incompatible? Some clients are incredibly active and will definitely be updated with the REST API, while some inactive ones probably won't. I would be happy to go through and let you know which are inactive ones, but this would be challenging to keep updated at all times, so I agree that this information shouldn't live there long-term.
I have talked previously with the Marketplace team about adding other content, much like we added process blueprints earlier this year. I think this would be the best home for them, eventually, but it's not on the roadmap currently (as far as I know). Then we'd link the relevant docs pages to the Marketplace, with the Marketplace having the up-to-date information. My preference is to keep them listed in the docs for now, for a few reasons:
I also think, generally, we should prioritize officially supported content and direct folks to the Community Hub (or the relevant link, if not the Community Hub) for the most updated version of all community-maintained projects. Minimizing the number of pages that Clients have in the docs is totally fine by me, it's a little bloated at the moment. |
@xomiamoore can you clarify which will work with v1 and which will work with v2 APIs, as well as which are active and/or which could likely be removed?
I can ensure any community clients we keep clearly link to the Community Hub/related link 👍 @aleksander-dytko Does this impact your opinion on where you would like to see community clients placed in the sidebar? |
My understanding is most (if not all) community clients are Zeebe-only to address the gRPC-only API we had for Zeebe in previous versions. I would want to be super clear about this until maintainers are able to provide a client surface for all components (likely via the Camunda 8 REST API). In fact, Build your own client is really only for Zeebe too. I would also like to see us reduce the number of individual community-supported client pages we have to a single page. @christinaausley @xomiamoore WDYT about consolidating the info down to https://docs.camunda.io/docs/next/apis-tools/community-clients/ and just point to the source code. It's easier for us to maintain, but keeps the visibility in the docs. |
I think this is great! I can adjust in this PR. |
👋 🤖 🤔 Hello, @christinaausley! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
@akeller I've removed the community clients in |
@christinaausley the merge looks good, but I would take it a step further so the structure looks like this:
No backporting, as these changes would be for 8.7+. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since @aleksander-dytko is still on FTO, I'm going to approve this. @christinaausley please sync with him if he has further changes.
🧹 Preview environment for this PR has been torn down. |
Description
Related to https://docs.google.com/document/d/1_iWR1nzSiTZYK2K59YUDz-kLboQMGSuZiej82Ha74XY/edit?disco=AAABXuNNRhk.
Combines Clients and SDKs in sidebar.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).