-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Zeebe REST API #4650
Remove Zeebe REST API #4650
Conversation
👋 🤖 🤔 Hello, @christinaausley! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
The build currently breaks in part due to the migration guide for user tasks, work that I see happening over on #4573. |
Do we also remove this from the |
I would assume so. Once I get #4573 merged in I'll get this cleaned up and merged as well. CC @volodymyr-melnykc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, content-wise 👍
I'm not sure if there are other structural leftovers for the Zeebe API, I guess @pepopowitz knows this best 🙂
@pepopowitz can you review to make sure we've made all the docs infra changes necessary to remove the Zeebe REST API? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the inline comment, I also think this block is what's giving you a build error right now, and should be removed.
Other than that I think you cleaned everything up!
@tmetzke Can you confirm if the Zeebe REST API should be removed in 8.5 and 8.6? |
As far as I know, we keep it there. @felix-mueller (covering for @aleksander-dytko), can you confirm or deny? 😄 |
I've confirmed with @felix-mueller this is still valid for 8.5 and 8.6, so this PR is ready for final review. @tmetzke Would you like me to keep this API in Postman for now, or remove it with an announcement to migrate to the Camunda 8 API? |
Let's add an announcement to move to C8 API 👍 |
versioned_docs/version-8.5/apis-tools/tasklist-api-rest/migrate-to-zeebe-user-tasks.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me, thanks for tracking it down everywhere 🚀
🔧 Only one spot left that might need some attention.
Pre-approving since my last suggestion is not blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
🪦 Removing the deprecated Zeebe REST API. 🪦
I think this can be separate from a specific alpha, so it can be reviewed and merged whenever (unless @tmetzke or @aleksander-dytko think differently).
Remaining items to bring this PR out of draft status:
@camunda/tech-writers one of you can take this over while I'm gone to get it merged.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
My changes are for an already released minor and are in
/versioned_docs
directory.My changes are for the next minor and are in
/docs
directory (aka/next/
).I (will) added a redirect for a renamed or deleted page to the .htaccess file.