Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Zeebe REST API #4650

Merged
merged 15 commits into from
Dec 17, 2024
Merged

Remove Zeebe REST API #4650

merged 15 commits into from
Dec 17, 2024

Conversation

akeller
Copy link
Member

@akeller akeller commented Nov 22, 2024

Description

🪦 Removing the deprecated Zeebe REST API. 🪦

I think this can be separate from a specific alpha, so it can be reviewed and merged whenever (unless @tmetzke or @aleksander-dytko think differently).

Remaining items to bring this PR out of draft status:

  • Redirects (to the Camunda REST API)
  • Backporting (content removal only, not announcement)

@camunda/tech-writers one of you can take this over while I'm gone to get it merged.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.

  • My changes are for the next minor and are in /docs directory (aka /next/).

  • I (will) added a redirect for a renamed or deleted page to the .htaccess file.

@akeller akeller added the target:8.7 Issues included in the 8.7 release label Nov 22, 2024
@akeller akeller requested review from tmetzke, aleksander-dytko and a team November 22, 2024 22:16
@akeller akeller self-assigned this Nov 22, 2024
Copy link
Contributor

github-actions bot commented Nov 22, 2024

👋 🤖 🤔 Hello, @christinaausley! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.

  • docs/apis-tools/frontend-development/01-task-applications/02-user-task-lifecycle.md
  • docs/apis-tools/spring-zeebe-sdk/getting-started.md
  • docs/apis-tools/zeebe-api-rest/sidebar-schema.js
  • docs/apis-tools/zeebe-api-rest/specifications/assign-a-user-task.api.mdx
  • docs/apis-tools/zeebe-api-rest/specifications/complete-a-user-task.api.mdx
  • docs/apis-tools/zeebe-api-rest/specifications/get-cluster-topology.api.mdx
  • docs/apis-tools/zeebe-api-rest/specifications/sidebar.js
  • docs/apis-tools/zeebe-api-rest/specifications/unassign-a-user-task.api.mdx
  • docs/apis-tools/zeebe-api-rest/specifications/update-a-user-task.api.mdx
  • docs/apis-tools/zeebe-api-rest/specifications/zeebe-rest-api.info.mdx
  • docs/apis-tools/zeebe-api-rest/tutorial.md
  • docs/apis-tools/zeebe-api-rest/zeebe-api-rest-authentication.md
  • docs/apis-tools/zeebe-api-rest/zeebe-api-rest-overview.md
  • docs/components/console/manage-clusters/manage-api-clients.md
  • docs/components/zeebe/technical-concepts/architecture.md
  • docs/guides/setup-client-connection-credentials.md
  • docs/self-managed/zeebe-deployment/operations/management-api.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@akeller
Copy link
Member Author

akeller commented Nov 22, 2024

The build currently breaks in part due to the migration guide for user tasks, work that I see happening over on #4573.

@christinaausley christinaausley self-assigned this Nov 25, 2024
@tmetzke
Copy link
Member

tmetzke commented Nov 27, 2024

Do we also remove this from the /api directory? There are some references to that. Not sure if this needs to be part of this PR or is a follow-up since that is more about internal structure changes than user-facing docs.

@christinaausley
Copy link
Contributor

christinaausley commented Dec 2, 2024

Do we also remove this from the /api directory? There are some references to that. Not sure if this needs to be part of this PR or is a follow-up since that is more about internal structure changes than user-facing docs.

I would assume so. Once I get #4573 merged in I'll get this cleaned up and merged as well. CC @volodymyr-melnykc

tmetzke
tmetzke previously approved these changes Dec 4, 2024
Copy link
Member

@tmetzke tmetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, content-wise 👍
I'm not sure if there are other structural leftovers for the Zeebe API, I guess @pepopowitz knows this best 🙂

@akeller akeller requested a review from pepopowitz December 4, 2024 18:52
@akeller
Copy link
Member Author

akeller commented Dec 4, 2024

Looks good to me, content-wise 👍 I'm not sure if there are other structural leftovers for the Zeebe API, I guess @pepopowitz knows this best 🙂

@pepopowitz can you review to make sure we've made all the docs infra changes necessary to remove the Zeebe REST API?

Copy link
Collaborator

@pepopowitz pepopowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the inline comment, I also think this block is what's giving you a build error right now, and should be removed.

Other than that I think you cleaned everything up!

static/.htaccess Outdated Show resolved Hide resolved
@christinaausley
Copy link
Contributor

@tmetzke Can you confirm if the Zeebe REST API should be removed in 8.5 and 8.6?

@tmetzke
Copy link
Member

tmetzke commented Dec 9, 2024

@tmetzke Can you confirm if the Zeebe REST API should be removed in 8.5 and 8.6?

As far as I know, we keep it there. @felix-mueller (covering for @aleksander-dytko), can you confirm or deny? 😄

@christinaausley christinaausley marked this pull request as ready for review December 9, 2024 15:29
@christinaausley
Copy link
Contributor

I've confirmed with @felix-mueller this is still valid for 8.5 and 8.6, so this PR is ready for final review.

@tmetzke Would you like me to keep this API in Postman for now, or remove it with an announcement to migrate to the Camunda 8 API?

@tmetzke
Copy link
Member

tmetzke commented Dec 9, 2024

@tmetzke Would you like me to keep this API in Postman for now, or remove it with an announcement to migrate to the Camunda 8 API?

Let's add an announcement to move to C8 API 👍

tmetzke
tmetzke previously approved these changes Dec 13, 2024
Copy link
Member

@tmetzke tmetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me, thanks for tracking it down everywhere 🚀
🔧 Only one spot left that might need some attention.

Pre-approving since my last suggestion is not blocking.

Copy link
Collaborator

@pepopowitz pepopowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!!

image

@christinaausley christinaausley merged commit 74fa8ef into main Dec 17, 2024
10 checks passed
@christinaausley christinaausley deleted the remove-zeebe-rest branch December 17, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target:8.7 Issues included in the 8.7 release
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants