-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline-image style for BPMN icon images #4647
Conversation
👋 🤖 🤔 Hello, @mesellings! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The BPMN diagrams from BPMN.io and the icons don't seem to want to load at all in the preview environment, so I'll pull this down and run it locally.
Related, the BPMN diagrams from BPMN.io load slow on production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good when running locally! Thank you!
BTW, I saw you removed "like" from the sentence. I think this is trying to communicate that it's an example gateway symbol as there are multiple.
Hi @camunda/tech-writers please can I get an approval as Amara is away this week? I just added the word "such as" back in after prior approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea why these don't build in the preview, but the images do look great locally -thanks for this fix!
🧹 Preview environment for this PR has been torn down. |
Description
Closes #4629.
This is a quick fix that applies an inline style to these BPMN icon images to at least make them smaller and remove borders, padding, and so on.
However, some of these icons already have vertical spacing within the SVG, and we shouldn't changes these icons without understanding the impact on wherever else these are used in the docs. As a result, the gateway icon does not 'sit' on the baseline.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).