Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive(8.2) exclusion: physically remove files. Part 2, chonky boi. #4642

Merged
merged 9 commits into from
Nov 22, 2024

Conversation

pepopowitz
Copy link
Collaborator

@pepopowitz pepopowitz commented Nov 21, 2024

This PR currently targets the branch for #4641. That PR should at least be reviewed before merging this one, to keep it in a reviewable state.

This PR is also unlikely to ever be green, because there are so many changes that it breaks some of our CI checks.

Description

Part of #4527.

Physically removes the 8.2/3.10.0 content from the docs. This is the final step in archiving this unsupported version.

Since it's hard to view in the browser, these are the commands I ran for this PR:

rm -rf ./versioned_docs/version-8.2/
rm ./versioned_sidebars/version-8.2-sidebars.json
rm -rf ./optimize_versioned_docs/version-3.10.0/
rm ./optimize_versioned_sidebars/version-3.10.0-sidebars.json

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@pepopowitz pepopowitz self-assigned this Nov 21, 2024
@pepopowitz pepopowitz requested a review from akeller November 21, 2024 21:41
akeller
akeller previously approved these changes Nov 21, 2024
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out a new computer helps me review these massive changes! Sidebars and versioned docs directories appear to be as I expect them and the PR is all deletions. ✅

Base automatically changed from pepopowitz/4527-archive-8-2/exclude-reviewable to main November 22, 2024 17:32
@pepopowitz pepopowitz dismissed akeller’s stale review November 22, 2024 17:32

The base branch was changed.

@pepopowitz pepopowitz requested a review from akeller November 22, 2024 17:33
@pepopowitz pepopowitz merged commit dfba37a into main Nov 22, 2024
5 of 7 checks passed
@pepopowitz pepopowitz deleted the pepopowitz/4527-archive-8-2/exclude-chonky-boi branch November 22, 2024 20:04
@pepopowitz pepopowitz mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants