Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trial pause docs #4636

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Update trial pause docs #4636

merged 4 commits into from
Nov 21, 2024

Conversation

Sijoma
Copy link
Contributor

@Sijoma Sijoma commented Nov 21, 2024

The first statement says "No data is lost", the second then "disk space is cleared".

I think we can keep it simple and just keep the latter.

Still needs to be back ported to all versions.

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

These statements conflict each other.
Copy link
Contributor

github-actions bot commented Nov 21, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@Sijoma Sijoma requested a review from ultraschuppi November 21, 2024 07:35
@Sijoma Sijoma changed the title Update clusters.md Update trial pause docs Nov 21, 2024
@Sijoma Sijoma force-pushed the fix-conficlting-statements branch from 00aa0dc to 665c363 Compare November 21, 2024 07:45
ultraschuppi
ultraschuppi previously approved these changes Nov 21, 2024
Copy link
Contributor

@ultraschuppi ultraschuppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to get the docs out, but just some concerns to check:

  • Does this mean paused dev tagged clusters are no longer automatically deleted after 30 paused days? You are removing this so I assume so?
  • We no longer need to backport to 8.2 as it is being archived currently, but I can fix that in a follow-up PR once I'm properly back online

@mesellings mesellings merged commit 423d423 into main Nov 21, 2024
8 checks passed
@mesellings mesellings deleted the fix-conficlting-statements branch November 21, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants