-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web-modeler): add git-sync self-hosted part #4630
Conversation
6d45067
to
f0e7489
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
f0e7489
to
ce41a72
Compare
@conceptualshark, I also added an alternative to also use Application ID instead of client ID in the docs. Please give me another round of review for that if you want and merge if everything is good to go 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small suggestion, and I do think some of the wording changes suggested for the note could be helpful, but both are non-blocking and I am good with where this PR is!
Co-authored-by: Cole Isaac <[email protected]>
Could someone approve this again so it can be merged, @jfriedenstab or @conceptualshark? I forgot about this because I enabled auto-merge, but it wasn't auto-merged because of a missing approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not checked content, approving to unblock as per request from @JacobiCamunda 👍
Description
Add documentation part when using self-hosted GitHub instances (See PR). We will release a release-candidate for 8.6 today so that a customer can already run some tests, and it should be released somewhere today or tomorrow.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).