Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-modeler): add git-sync self-hosted part #4630

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

JacobiCamunda
Copy link
Contributor

@JacobiCamunda JacobiCamunda commented Nov 20, 2024

Description

Add documentation part when using self-hosted GitHub instances (See PR). We will release a release-candidate for 8.6 today so that a customer can already run some tests, and it should be released somewhere today or tomorrow.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.
  • This will be part of a release-candidate (released today 20.11.24)

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@JacobiCamunda JacobiCamunda added the component:web-modeler-sm Issues related with Web Modeler Self-Managed label Nov 20, 2024
@JacobiCamunda JacobiCamunda self-assigned this Nov 20, 2024
marcellobarile
marcellobarile previously approved these changes Nov 20, 2024
jfriedenstab
jfriedenstab previously approved these changes Nov 20, 2024
Copy link
Contributor

@jfriedenstab jfriedenstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jfriedenstab jfriedenstab requested a review from a team November 20, 2024 17:13
@JacobiCamunda
Copy link
Contributor Author

@conceptualshark, I also added an alternative to also use Application ID instead of client ID in the docs. Please give me another round of review for that if you want and merge if everything is good to go 🙂

Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion, and I do think some of the wording changes suggested for the note could be helpful, but both are non-blocking and I am good with where this PR is!

@JacobiCamunda JacobiCamunda enabled auto-merge (squash) November 22, 2024 14:16
@JacobiCamunda
Copy link
Contributor Author

Could someone approve this again so it can be merged, @jfriedenstab or @conceptualshark? I forgot about this because I enabled auto-merge, but it wasn't auto-merged because of a missing approval.

@mesellings mesellings self-requested a review December 9, 2024 09:10
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not checked content, approving to unblock as per request from @JacobiCamunda 👍

@JacobiCamunda JacobiCamunda merged commit dbb5f6c into main Dec 9, 2024
10 checks passed
@JacobiCamunda JacobiCamunda deleted the webmodeler-gitsync-self-hosted branch December 9, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:web-modeler-sm Issues related with Web Modeler Self-Managed
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants