Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(concepts): suspend free trial #4608

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Conversation

Sijoma
Copy link
Contributor

@Sijoma Sijoma commented Nov 15, 2024

Description

The disks are getting deleted on a trial suspension. This needs to be explained in order to prevent confusion and explain what are actions the user then needs to perform to get their processes running again.
This also explains what is actually retained for the cluster.

@mesellings although this is a minor change, I would be still interested for your input. The concept of "suspension but still deleting disks" could be a bit confusing & surprsing.

This is also version independent. Do we back port concepts?

Documentation for PDP: https://github.com/camunda/product-hub/issues/2548
https://github.com/camunda-cloud/camunda-operator/issues/3412

When should this change go live?

We target a release mid-next week. I would not object to already release it Monday before we rollout the change to decouple the timeline a bit.

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Copy link
Contributor

github-actions bot commented Nov 15, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

- disk deletion on suspension
- explanation whats retained & to be done if it occurs
@Sijoma Sijoma force-pushed the feat-suspend-delete-disks-doc branch from 16087ee to 60d059b Compare November 15, 2024 13:05
@Sijoma Sijoma requested a review from mesellings November 15, 2024 13:05
@mesellings mesellings added kind/enhancement Issues related with enhancing existing documentation or the documentation structure (nice to have) component:docs Documentation improvements, including new or updated content component:console Issues related with Console project deploy Stand up a temporary docs site with this PR labels Nov 15, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs November 15, 2024 14:24 Destroyed
@mesellings
Copy link
Contributor

@Sijoma I've committed some edits - if you are happy with these, I can backport the changes, approve the PR, and get this published 👍

@mesellings mesellings self-assigned this Nov 18, 2024
mesellings
mesellings previously approved these changes Nov 18, 2024
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍 🚀

@mesellings
Copy link
Contributor

@Sijoma I've backported and approved for you 👍

@Sijoma
Copy link
Contributor Author

Sijoma commented Nov 18, 2024

@Sijoma I've committed some edits - if you are happy with these, I can backport the changes, approve the PR, and get this published 👍

looks good! TY

@mesellings mesellings removed the deploy Stand up a temporary docs site with this PR label Nov 18, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs November 18, 2024 16:23 Destroyed
Copy link
Contributor

The preview environment relating to the commit a104dc1 has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-4608/index.html

@mesellings
Copy link
Contributor

To be merged and docs released Tuesday 19/Weds 20 depending on QA.

@mesellings mesellings added the hold This issue is parked, do not merge. label Nov 18, 2024
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🚀

@Sijoma Sijoma enabled auto-merge (squash) November 20, 2024 08:03
@Sijoma Sijoma removed the hold This issue is parked, do not merge. label Nov 20, 2024
@Sijoma Sijoma merged commit 7552123 into main Nov 20, 2024
8 of 9 checks passed
@Sijoma Sijoma deleted the feat-suspend-delete-disks-doc branch November 20, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:console Issues related with Console project component:docs Documentation improvements, including new or updated content kind/enhancement Issues related with enhancing existing documentation or the documentation structure (nice to have)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants