Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stale Connectors update guide #4594

Closed
wants to merge 8 commits into from

Conversation

akeller
Copy link
Member

@akeller akeller commented Nov 12, 2024

Description

Via https://camunda.slack.com/archives/C02JLRNQQ05/p1731098751001189.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@akeller akeller added the component:connectors Issues related to the connectors project. label Nov 12, 2024
@akeller akeller requested a review from sbuettner November 12, 2024 15:38
@akeller akeller self-assigned this Nov 12, 2024
@akeller akeller added the deploy Stand up a temporary docs site with this PR label Nov 12, 2024
sbuettner
sbuettner previously approved these changes Nov 12, 2024
Copy link
Contributor

@sbuettner sbuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@akeller akeller changed the title remove 8.6 and 8.7 Remove stale Connectors update guide Nov 12, 2024
@akeller akeller marked this pull request as ready for review November 12, 2024 15:54
@akeller akeller requested a review from sbuettner November 12, 2024 16:44
@akeller
Copy link
Member Author

akeller commented Nov 12, 2024

@sbuettner, I removed the admonition in the connectors that pointed to the update guide because it also looked stale. Please take a look at that change specifically, but that should correct any link issues detected by the build workflow.

@github-actions github-actions bot temporarily deployed to camunda-docs November 12, 2024 17:01 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs November 12, 2024 18:08 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs November 12, 2024 18:46 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs November 12, 2024 19:58 Destroyed
@akeller
Copy link
Member Author

akeller commented Nov 12, 2024

@pepopowitz, can you look at these build errors? It looks like the partials aren't playing nice, but I didn't touch them in this PR. Any ideas?

@pepopowitz
Copy link
Collaborator

Yeah, I'm not sure what this is about either. I pulled the branch locally, and the links it's complaining about work for me.

I kicked off a re-run of build-docs, hoping it was a blip? 🤞

Copy link
Contributor

👋 🤖 🤔 Hello, @akeller! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.

  • docs/components/connectors/custom-built-connectors/connector-sdk.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@github-actions github-actions bot temporarily deployed to camunda-docs November 12, 2024 21:24 Destroyed
@akeller
Copy link
Member Author

akeller commented Nov 12, 2024

I don't know what's going on with the build here, and I'm giving up with debugging attempts. Join me over here while I fix the redirects - #4598

@akeller akeller closed this Nov 12, 2024
Copy link
Contributor

🧹 Preview environment for this PR has been torn down.

@akeller akeller mentioned this pull request Nov 15, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:connectors Issues related to the connectors project. deploy Stand up a temporary docs site with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants