-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2 architecture and guide #4585
Conversation
👋 🤖 🤔 Hello, @conceptualshark! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
@theburi and @conceptualshark maybe you could have a look over this next week and give some general feedback on maybe what you're missing and still expecting to see. I was going in the direction of GitLab's approach on the topic just that we don't have any benchmarks to guide (which I don't see happening anytime soon). Essentially, on a high level talking about the idea of Reference Architectures, actual architecture, and guiding customers along to choose their path based on
Current pages: I'm on a team event next week + RSG, so take your time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start. Lets discuss few topics as I was reading this guide:
- Adding Architecture tech spec, overview page that just lists facts
- Can we include full production configuration in a single page, including TLS, Auth and connectivity? Or shall we make it a multi-step guide: install foundation, then add security, then add connectivity.
- I feel like we need to add a bit more description to each step to describe what is going on.
Since the previous links were moved: |
docs/self-managed/reference-architecture/reference-architecture.md
Outdated
Show resolved
Hide resolved
docs/self-managed/reference-architecture/reference-architecture.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rock solid documentation! Wp
I left some comments
docs/self-managed/reference-architecture/reference-architecture.md
Outdated
Show resolved
Hide resolved
sidebars.js
Outdated
@@ -1567,5 +1567,16 @@ module.exports = { | |||
}, | |||
], | |||
}, | |||
{ | |||
"Reference Architecture": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could have the RA part of the Setup section, for existing docs such as gitlab, it's part of the Install chapter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had it previously but talked with Andrey about it, the idea is to have it more prominently as guidance in the future.
Not sure how long setup
will continue existing as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd keep the Reference Arch structure wise as is for now, we can still move it till 8.7 depending on feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only issue I see with that is the fact that this category is not self-describing.
Setup / Installation are simple words
Reference Arch needs its own definition
I don't have strong opinion on that, maybe @conceptualshark you have one regarding the developer experience of those words
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theburi maybe also of interest to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should leave it as-is for right now, knowing that the Setup section is going to undergo some changes, and given that Andrey also advised it standing on its own as a new "Reference architecture" section.
Broadly, I agree - I think it should be categorized as some sort of instructional section, including some of the existing deployment docs, but I think we can handle moving content and renaming this separate to what's happening in this PR.
docs/self-managed/reference-architecture/manual/manual-overview.md
Outdated
Show resolved
Hide resolved
docs/self-managed/reference-architecture/manual/manual-overview.md
Outdated
Show resolved
Hide resolved
docs/self-managed/reference-architecture/manual/manual-overview.md
Outdated
Show resolved
Hide resolved
docs/self-managed/reference-architecture/reference-architecture.md
Outdated
Show resolved
Hide resolved
docs/self-managed/reference-architecture/reference-architecture.md
Outdated
Show resolved
Hide resolved
|
||
<!-- TODO: add calculator specific for this setup --> | ||
To get an estimate, you can refer to this [example calculation](https://calculator.aws/#/estimate?id=8ce855e2d02d182c4910ec8b4ea2dbf42ea5fd1d), which can be further optimized to suit your specific use cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@conceptualshark added an example cost calculator for the setup, let me know when it makes sense to add this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Langleu I've gone ahead and made some changes and committed them here - the deploy/preview should be running in case you'd like to use that to double-check. Otherwise, this is looking good on my end!
@conceptualshark thank you 🙇. Looks good from my side as well, thanks for the additional changes! |
🧹 Preview environment for this PR has been torn down. |
Description
Draft/WIP PR to explore changes and content movement in the preview.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).