Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2 architecture and guide #4585

Merged
merged 31 commits into from
Dec 19, 2024
Merged

ec2 architecture and guide #4585

merged 31 commits into from
Dec 19, 2024

Conversation

conceptualshark
Copy link
Contributor

@conceptualshark conceptualshark commented Nov 8, 2024

Description

Draft/WIP PR to explore changes and content movement in the preview.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@conceptualshark conceptualshark self-assigned this Nov 8, 2024
@conceptualshark conceptualshark added the component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

👋 🤖 🤔 Hello, @conceptualshark! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.

  • docs/self-managed/reference-architecture/img/management-cluster.jpg
  • docs/self-managed/reference-architecture/img/orchestration-cluster.jpg
  • docs/self-managed/reference-architecture/manual/img/manual-ha.jpg
  • docs/self-managed/reference-architecture/manual/img/manual-single.jpg
  • docs/self-managed/reference-architecture/manual/manual.md
  • docs/self-managed/reference-architecture/reference-architecture.md
  • docs/self-managed/setup/deploy/amazon/assets/aws-ec2-arch.jpg
  • docs/self-managed/setup/deploy/amazon/assets/aws-ec2-arch.pdf
  • docs/self-managed/setup/deploy/amazon/aws-ec2.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@conceptualshark conceptualshark added target:8.7 Issues included in the 8.7 release deploy Stand up a temporary docs site with this PR labels Nov 8, 2024
@conceptualshark conceptualshark changed the title [draft] cg2 architecture and guide [draft] ec2 architecture and guide Nov 8, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs November 8, 2024 18:09 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs November 18, 2024 13:51 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs November 19, 2024 15:30 Destroyed
docs/self-managed/concepts/single-jar.md Outdated Show resolved Hide resolved
docs/self-managed/concepts/single-jar.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to camunda-docs November 20, 2024 15:25 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs November 21, 2024 14:38 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs November 22, 2024 15:07 Destroyed
@Langleu
Copy link
Member

Langleu commented Nov 22, 2024

@theburi and @conceptualshark maybe you could have a look over this next week and give some general feedback on maybe what you're missing and still expecting to see.

I was going in the direction of GitLab's approach on the topic just that we don't have any benchmarks to guide (which I don't see happening anytime soon).

Essentially, on a high level talking about the idea of Reference Architectures, actual architecture, and guiding customers along to choose their path based on Kubernetes || manual (single jar) and from there have dedicated pages that cover the specific architecture to that component, talk about general requirements, etc. etc. and lastly guide from there to existing reference implementations based on the examples that we have.

  • Reference Architecture
    • Kubernetes
      • AWS EKS
      • Dual Region
      • any other ...
    • Manual
      • AWS EC2
      • any other ...

Current pages:

I'm on a team event next week + RSG, so take your time!

Copy link
Contributor

@theburi theburi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start. Lets discuss few topics as I was reading this guide:

  1. Adding Architecture tech spec, overview page that just lists facts
  2. Can we include full production configuration in a single page, including TLS, Auth and connectivity? Or shall we make it a multi-step guide: install foundation, then add security, then add connectivity.
  3. I feel like we need to add a bit more description to each step to describe what is going on.

docs/self-managed/setup/deploy/amazon/aws-ec2.md Outdated Show resolved Hide resolved
docs/self-managed/setup/deploy/amazon/aws-ec2.md Outdated Show resolved Hide resolved
docs/self-managed/setup/deploy/amazon/aws-ec2.md Outdated Show resolved Hide resolved
docs/self-managed/setup/deploy/amazon/aws-ec2.md Outdated Show resolved Hide resolved
docs/self-managed/setup/deploy/amazon/aws-ec2.md Outdated Show resolved Hide resolved
docs/self-managed/setup/deploy/amazon/aws-ec2.md Outdated Show resolved Hide resolved
docs/self-managed/setup/deploy/amazon/aws-ec2.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to camunda-docs December 3, 2024 10:06 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs December 4, 2024 10:22 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs December 4, 2024 14:35 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs December 4, 2024 18:12 Destroyed
@Langleu Langleu requested a review from leiicamundi December 5, 2024 15:31
@Langleu Langleu marked this pull request as ready for review December 10, 2024 11:00
Copy link
Contributor

@leiicamundi leiicamundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock solid documentation! Wp

I left some comments

docs/self-managed/setup/deploy/local/manual.md Outdated Show resolved Hide resolved
sidebars.js Outdated
@@ -1567,5 +1567,16 @@ module.exports = {
},
],
},
{
"Reference Architecture": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could have the RA part of the Setup section, for existing docs such as gitlab, it's part of the Install chapter

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had it previously but talked with Andrey about it, the idea is to have it more prominently as guidance in the future.
Not sure how long setup will continue existing as is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep the Reference Arch structure wise as is for now, we can still move it till 8.7 depending on feedback.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue I see with that is the fact that this category is not self-describing.
Setup / Installation are simple words

Reference Arch needs its own definition

I don't have strong opinion on that, maybe @conceptualshark you have one regarding the developer experience of those words

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theburi maybe also of interest to you

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave it as-is for right now, knowing that the Setup section is going to undergo some changes, and given that Andrey also advised it standing on its own as a new "Reference architecture" section.

Broadly, I agree - I think it should be categorized as some sort of instructional section, including some of the existing deployment docs, but I think we can handle moving content and renaming this separate to what's happening in this PR.

optimize_sidebars.js Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to camunda-docs December 11, 2024 14:34 Destroyed
@Langleu Langleu requested a review from leiicamundi December 12, 2024 09:21
@github-actions github-actions bot temporarily deployed to camunda-docs December 17, 2024 09:27 Destroyed

<!-- TODO: add calculator specific for this setup -->
To get an estimate, you can refer to this [example calculation](https://calculator.aws/#/estimate?id=8ce855e2d02d182c4910ec8b4ea2dbf42ea5fd1d), which can be further optimized to suit your specific use cases.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conceptualshark added an example cost calculator for the setup, let me know when it makes sense to add this.

@github-actions github-actions bot temporarily deployed to camunda-docs December 17, 2024 13:11 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs December 17, 2024 21:06 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs December 18, 2024 20:01 Destroyed
Copy link
Contributor Author

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Langleu I've gone ahead and made some changes and committed them here - the deploy/preview should be running in case you'd like to use that to double-check. Otherwise, this is looking good on my end!

@Langleu
Copy link
Member

Langleu commented Dec 19, 2024

@conceptualshark thank you 🙇. Looks good from my side as well, thanks for the additional changes!
I'm good with merging this as well.

@conceptualshark conceptualshark merged commit 5df996f into main Dec 19, 2024
8 checks passed
@conceptualshark conceptualshark deleted the infraex-250 branch December 19, 2024 21:25
Copy link
Contributor

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:infex Issues related with InfEx project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed deploy Stand up a temporary docs site with this PR target:8.7 Issues included in the 8.7 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants