Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removing references to OpenSearch proxy #4549

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

grlimacan
Copy link
Contributor

@grlimacan grlimacan commented Nov 1, 2024

Description

In https://github.com/camunda/camunda-optimize/issues/10058 we have decided to de-scope the implementation for proxy for OpenSearch, so we are updating the documentation to reflect that

Same applies to the response buffer limit as described in camunda/camunda#24083

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@grlimacan grlimacan self-assigned this Nov 1, 2024
@grlimacan grlimacan added the deploy Stand up a temporary docs site with this PR label Nov 1, 2024
@grlimacan grlimacan force-pushed the optimize-10058-remove-refs-to-proxy branch from c868416 to 7f5eb55 Compare November 1, 2024 09:19
@github-actions github-actions bot temporarily deployed to camunda-docs November 1, 2024 09:37 Destroyed
@grlimacan grlimacan requested a review from a team November 1, 2024 09:44
Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me from my understanding of the linked issues, but I'm not certain if an engineering review would be prudent. Just to be certain, it seems like the ability to use the proxy was not ever implemented, only documented, and so there is no need to announce the removal?

@grlimacan
Copy link
Contributor Author

This looks good to me from my understanding of the linked issues, but I'm not certain if an engineering review would be prudent. Just to be certain, it seems like the ability to use the proxy was not ever implemented, only documented, and so there is no need to announce the removal?

That's correct, it was never implemented, so no announcement necessary

@grlimacan grlimacan merged commit f691bee into main Nov 4, 2024
8 checks passed
@grlimacan grlimacan deleted the optimize-10058-remove-refs-to-proxy branch November 4, 2024 08:58
Copy link
Contributor

github-actions bot commented Nov 4, 2024

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Stand up a temporary docs site with this PR
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants