-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add optimize translation diff #4390
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in optimize/. You might want to duplicate these changes in optimize_versioned_docs/version-3.13.0/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm 👍 (just one minor rewording suggestion for conciseness, but you do not need to incorporate)
|
||
[en.json.diff](../translation-diffs/differences_localization_313_314.diff) | ||
|
||
- Lines with a `+` in the beginning mark the addition/update of a term; lines with a `-` mark the removal of a term. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Lines with a `+` in the beginning mark the addition/update of a term; lines with a `-` mark the removal of a term. | |
- Lines with a `+` in the beginning mark a term addition/update. Lines with a `-` mark a term removal. |
Just a minor rewording suggestion, non-blocking 👍
31764f3
31764f3
to
b0a31ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm 👍 🚀
* chore: add optimize translation diff * refactor: use different wording
Description
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).