Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update instructions to add a blueprint #4371

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

christinaausley
Copy link
Contributor

Description

Partially closes https://github.com/camunda/developer-experience/issues/398.

Applying hold label as this should not be merged until https://github.com/camunda/web-modeler/pull/11106 is merged.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@christinaausley christinaausley added hold This issue is parked, do not merge. component:connectors Issues related to the connectors project. labels Oct 1, 2024
@christinaausley christinaausley requested review from YanaSegal and a team October 1, 2024 14:21
@christinaausley christinaausley self-assigned this Oct 1, 2024
@mesellings mesellings requested review from mesellings and removed request for a team October 1, 2024 14:47
mesellings
mesellings previously approved these changes Oct 1, 2024
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍 (just a non-blocking rewording/list suggestion, feel free to ignore).

docs/components/modeler/web-modeler/launch-web-modeler.md Outdated Show resolved Hide resolved
YanaSegal
YanaSegal previously approved these changes Oct 1, 2024
Copy link
Contributor

@YanaSegal YanaSegal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christinaausley christinaausley dismissed stale reviews from YanaSegal and mesellings via fcb7bba October 2, 2024 14:15
@christinaausley
Copy link
Contributor Author

This is ready for final review 👍 Updated the screenshot and moved a bit of content around.

Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, nice work! 👍 🚀

Copy link
Contributor

@YanaSegal YanaSegal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@akeller
Copy link
Member

akeller commented Oct 7, 2024

@christinaausley this looks ready to merge, can you confirm?

@christinaausley
Copy link
Contributor Author

christinaausley commented Oct 7, 2024

@christinaausley this looks ready to merge, can you confirm?

There has not been a Web Modeler release with this UI update (but the PR is merged in so that's good!), so I've been hanging on to it. I can always backport if need be. @akeller

@christinaausley
Copy link
Contributor Author

Update that this has not yet been updated in the UI, but once a release goes out with https://github.com/camunda/marketplace-api/pull/91 it should be.

@christinaausley
Copy link
Contributor Author

This is now live in the product -- thank you @ev-codes!

@christinaausley christinaausley removed the hold This issue is parked, do not merge. label Nov 12, 2024
@christinaausley christinaausley enabled auto-merge (squash) November 12, 2024 15:55
@christinaausley christinaausley merged commit aa2e0de into main Nov 12, 2024
10 of 11 checks passed
@christinaausley christinaausley deleted the rephrase-adding-blueprint branch November 12, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:connectors Issues related to the connectors project.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants