-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a warning for Keycloak URL changes after 8.5 #4294
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in versioned_docs/version-8.5/. You might want to duplicate these changes in docs/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
Assuming there's no config change needed, I think this represents the best places to add the note. Since it was missed in the initial announcements, I've added it to both the 8.5 and /next connection guide, so it isn't lost in prior update guides users may not think apply to them. |
docs/self-managed/identity/user-guide/configuration/connect-to-an-existing-keycloak.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm - just a suggestion about addressing the customer directly, but feel free to ignore 👍
docs/self-managed/identity/user-guide/configuration/connect-to-an-existing-keycloak.md
Outdated
Show resolved
Hide resolved
docs/self-managed/operational-guides/update-guide/840-to-850.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm 👍 🚀
Description
In 8.5, a change to Identity to use the frontend URL instead of the backend url was not documented. In some cases, users may be blocking the frontend URL, causing impacts to functionality.
This PR adds the warning to the 8.5 announcements and the 8.4 - > 8.5 upgrade guides, and adds the note for visibility in the Keycloak connection guides for 8.5 and 8.6.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).