-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metrics env var requirement #4262
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
|
||
Configure the HTTP server to export the metrics in the [configuration file](../configuration/configuration.md). | ||
To export metrics, set the `ZEEBE_BROKER_EXECUTION_METRICS_EXPORTER_ENABLED` environment variable to `true` in your Zeebe [configuration file](../configuration/configuration.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 This configuration flag is enabling just one very specific type of metrics, the so called execution metrics. Even without this set, Zeebe exports many more metrics automatically by default. No extra configuration is required for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Do any changes need to be made to the config at all to export metrics?
- Are there other flags that should be added here (to enable metrics which aren't exported by default)? I'd like to make this section as complete as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do any changes need to be made to the config at all to export metrics?
No, metrics are enabled by default.
Are there other flags that should be added here (to enable metrics which aren't exported by default)?
There are various flags that enable additional metrics. We leave them disabled by default because they have a performance impact and have a high cost to collect. For example:
ZEEBE_BROKER_EXPERIMENTAL_ROCKSDB_ACCESSMETRICS=fine
ZEEBE_BROKER_EXPERIMENTAL_FEATURES_ENABLEACTORMETRICS=true
I'd suggest to not mention them here, they are really only needed for debugging and performance tuning.
@lenaschoenburg I've updated this to be more clear based on your comments. Assuming the execution metrics aren't experimental, is it worth calling out here? The original ask was specifically about how to find them, so there's definitely an interest in knowing, and they don't seem to be in any of our example YAML or I'd link there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up. Looks good to me 👍
Description
Resolves #179
The "Configure the HTTP server" line is unhelpful/not descriptive. Update this to include mention of the actual env var required to configure metrics.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).