Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metrics env var requirement #4262

Merged
merged 3 commits into from
Sep 10, 2024
Merged

add metrics env var requirement #4262

merged 3 commits into from
Sep 10, 2024

Conversation

conceptualshark
Copy link
Contributor

@conceptualshark conceptualshark commented Sep 5, 2024

Description

Resolves #179

The "Configure the HTTP server" line is unhelpful/not descriptive. Update this to include mention of the actual env var required to configure metrics.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@conceptualshark conceptualshark added component:zeebe Issues related with Zeebe project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed labels Sep 5, 2024
@conceptualshark conceptualshark self-assigned this Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/self-managed/zeebe-deployment/operations/metrics.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@conceptualshark conceptualshark marked this pull request as ready for review September 6, 2024 13:57

Configure the HTTP server to export the metrics in the [configuration file](../configuration/configuration.md).
To export metrics, set the `ZEEBE_BROKER_EXECUTION_METRICS_EXPORTER_ENABLED` environment variable to `true` in your Zeebe [configuration file](../configuration/configuration.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 This configuration flag is enabling just one very specific type of metrics, the so called execution metrics. Even without this set, Zeebe exports many more metrics automatically by default. No extra configuration is required for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Do any changes need to be made to the config at all to export metrics?
  • Are there other flags that should be added here (to enable metrics which aren't exported by default)? I'd like to make this section as complete as possible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any changes need to be made to the config at all to export metrics?

No, metrics are enabled by default.

Are there other flags that should be added here (to enable metrics which aren't exported by default)?

There are various flags that enable additional metrics. We leave them disabled by default because they have a performance impact and have a high cost to collect. For example:

  • ZEEBE_BROKER_EXPERIMENTAL_ROCKSDB_ACCESSMETRICS=fine
  • ZEEBE_BROKER_EXPERIMENTAL_FEATURES_ENABLEACTORMETRICS=true

I'd suggest to not mention them here, they are really only needed for debugging and performance tuning.

@conceptualshark
Copy link
Contributor Author

@lenaschoenburg I've updated this to be more clear based on your comments. Assuming the execution metrics aren't experimental, is it worth calling out here? The original ask was specifically about how to find them, so there's definitely an interest in knowing, and they don't seem to be in any of our example YAML or I'd link there.

Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up. Looks good to me 👍

@conceptualshark conceptualshark merged commit c921402 into main Sep 10, 2024
7 checks passed
@conceptualshark conceptualshark deleted the cg-metrics-page branch September 10, 2024 13:52
@conceptualshark conceptualshark mentioned this pull request Sep 10, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed component:zeebe Issues related with Zeebe project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants