Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(concepts): Improve Execution Listener documentation #4233

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

ce-dmelnych
Copy link
Contributor

@ce-dmelnych ce-dmelnych commented Sep 2, 2024

Description

Relates to: camunda/camunda#16217

This PR improves the documentation for Execution Listeners. It builds on the initial documentation and received feedback to improve clarity and provide more comprehensive guidance for developers.

Scope:

  • Added details about the blocking behavior of ELs
  • Described how the system handles incidents raised during EL job or expression failures.
  • Updated limitations section.
  • Enhanced documentation structure and added references to relevant resources & code example.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Scope:
- Added details about the blocking behavior of ELs
- Described how the system handles incidents raised during EL job or expression failures.
- Updated limitations section.
- Enhanced documentation structure and added references to relevant resources & code example.
@ce-dmelnych ce-dmelnych self-assigned this Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 2, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/components/concepts/execution-listeners.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@ce-dmelnych ce-dmelnych linked an issue Sep 2, 2024 that may be closed by this pull request
@ce-dmelnych ce-dmelnych added component:zeebe Issues related with Zeebe project 8.6.0-alpha5 September 2024 alpha release deploy Stand up a temporary docs site with this PR labels Sep 2, 2024
@ce-dmelnych ce-dmelnych changed the title docs(concepts): improve Execution Listener documentation docs(concepts): Improve Execution Listener documentation Sep 2, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs September 2, 2024 05:08 Destroyed
@ce-dmelnych
Copy link
Contributor Author

Preview environment with update Execution Listeners page.

@ce-dmelnych ce-dmelnych marked this pull request as ready for review September 2, 2024 05:25
tmetzke
tmetzke previously approved these changes Sep 2, 2024
Copy link
Member

@tmetzke tmetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks, @ce-dmelnych, that will help users understand listeners a lot better 👍

@ce-dmelnych ce-dmelnych requested a review from akeller September 3, 2024 09:19
@akeller akeller requested review from a team and removed request for akeller and christinaausley September 3, 2024 20:03
@mesellings mesellings requested review from mesellings and removed request for a team September 4, 2024 08:00
@mesellings mesellings self-assigned this Sep 4, 2024
@mesellings
Copy link
Contributor

@tmetzke I will do a review for you now 👍

mesellings
mesellings previously approved these changes Sep 4, 2024
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ce-dmelnych I have completed the review and made commits directly into the branch:

  • Edits for structure (headings, tables)
  • Readability, active voice edits
  • Style guide edits (for example, we do not use "e.g.", but rather "for example," or "such as")

Happy to approve, nice work! 👍

@github-actions github-actions bot temporarily deployed to camunda-docs September 4, 2024 09:14 Destroyed
@mesellings
Copy link
Contributor

@ce-dmelnych Would you like me to merge this?

@ce-dmelnych
Copy link
Contributor Author

@mesellings Thank you for your efforts! The documentation looks great with your improvements 🎉

One small note: it might be better to present the text under Job execution failure and Expression evaluation failure headings as paragraphs instead of list items. Using items could potentially confuse users by making the explanations appear fragmented.

What do you think?

@mesellings
Copy link
Contributor

mesellings commented Sep 4, 2024

@ce-dmelnych I would normally try and avoid very verbose paragraphs like this if I can (hence splitting the sentences into bullets) to avoid cognitive overload when reading, but as you know the subject matter better than I do, happy if you want to have these as paragraphs, but perhaps split the sentences on new lines?

For example:

If an execution listener job fails (for example, if an external service is unavailable), it is retried according to the retries property.

If all retries are exhausted and the job still fails, the process halts, and an incident is raised. Once the incident is resolved, only the listener with the failed job is retried, allowing the process to resume from the point of failure without re-executing successfully completed listeners.

@ce-dmelnych
Copy link
Contributor Author

@mesellings Thanks for sharing your perspective!
I see your point about avoiding cognitive overload with long paragraphs. Splitting the sentences on new lines as you suggested could be a good compromise, making it easier to read without the potential confusion of bullet points as the items are tightly connected.

Let's go with the approach of using separate lines for clarity.

I appreciate your flexibility and input!

@mesellings
Copy link
Contributor

@ce-dmelnych Sounds good! 👍

@mesellings
Copy link
Contributor

@ce-dmelnych I still have the branch open, want me to make the changes quickly?

@ce-dmelnych
Copy link
Contributor Author

@ce-dmelnych I still have the branch open, want me to make the changes quickly?

@mesellings
That would be great, thank you!

@mesellings
Copy link
Contributor

@ce-dmelnych changes made, all good to go:

  • Changed bullets to paras
  • Removed superfluous line as now not needed

image

@github-actions github-actions bot temporarily deployed to camunda-docs September 4, 2024 10:44 Destroyed
@mesellings mesellings self-requested a review September 4, 2024 12:18
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍

@github-actions github-actions bot temporarily deployed to camunda-docs September 4, 2024 12:26 Destroyed
@mesellings
Copy link
Contributor

mesellings commented Sep 4, 2024

@ce-dmelnych Are you happy for us to merge this now, or do you want to wait for next Mon/Tue?

@mesellings mesellings removed the deploy Stand up a temporary docs site with this PR label Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

🧹 Preview environment for this PR has been torn down.

@ce-dmelnych
Copy link
Contributor Author

@mesellings
I'm happy for it to be merged now, no need to wait. Thanks for checking!

@mesellings mesellings merged commit 2f61cfb into main Sep 4, 2024
10 checks passed
@mesellings mesellings deleted the docs-16217-improve-EL-documentation branch September 4, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.6.0-alpha5 September 2024 alpha release component:zeebe Issues related with Zeebe project
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve Execution Listener documentation
3 participants