-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(concepts): Improve Execution Listener documentation #4233
Conversation
Scope: - Added details about the blocking behavior of ELs - Described how the system handles incidents raised during EL job or expression failures. - Updated limitations section. - Enhanced documentation structure and added references to relevant resources & code example.
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
Preview environment with update Execution Listeners page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks, @ce-dmelnych, that will help users understand listeners a lot better 👍
@tmetzke I will do a review for you now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ce-dmelnych I have completed the review and made commits directly into the branch:
- Edits for structure (headings, tables)
- Readability, active voice edits
- Style guide edits (for example, we do not use "e.g.", but rather "for example," or "such as")
Happy to approve, nice work! 👍
@ce-dmelnych Would you like me to merge this? |
@mesellings Thank you for your efforts! The documentation looks great with your improvements 🎉 One small note: it might be better to present the text under What do you think? |
@ce-dmelnych I would normally try and avoid very verbose paragraphs like this if I can (hence splitting the sentences into bullets) to avoid cognitive overload when reading, but as you know the subject matter better than I do, happy if you want to have these as paragraphs, but perhaps split the sentences on new lines? For example:
|
@mesellings Thanks for sharing your perspective! Let's go with the approach of using separate lines for clarity. I appreciate your flexibility and input! |
@ce-dmelnych Sounds good! 👍 |
@ce-dmelnych I still have the branch open, want me to make the changes quickly? |
@mesellings |
@ce-dmelnych changes made, all good to go:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 👍
@ce-dmelnych Are you happy for us to merge this now, or do you want to wait for next Mon/Tue? |
🧹 Preview environment for this PR has been torn down. |
@mesellings |
Description
Relates to: camunda/camunda#16217
This PR improves the documentation for Execution Listeners. It builds on the initial documentation and received feedback to improve clarity and provide more comprehensive guidance for developers.
Scope:
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).