Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update writing-good-workers.md #4231

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Update writing-good-workers.md #4231

merged 1 commit into from
Sep 6, 2024

Conversation

jwulf
Copy link
Member

@jwulf jwulf commented Sep 2, 2024

Description

Update Node.js client references to the new SDK.

Related to #3819

When should this change go live?

Anytime now.

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Copy link
Contributor

github-actions bot commented Sep 2, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/components/best-practices/development/writing-good-workers.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@akeller akeller requested review from a team and removed request for christinaausley September 3, 2024 18:41
@akeller akeller added the component:docs Documentation improvements, including new or updated content label Sep 3, 2024
@akeller
Copy link
Member

akeller commented Sep 3, 2024

@jwulf can this be backported to 8.5? Or is it only applicable to 8.6? I saw #4232

I've added @camunda/tech-writers since Christina is on FTO.

@mesellings mesellings requested review from mesellings and removed request for a team September 4, 2024 09:19
@mesellings mesellings added the deploy Stand up a temporary docs site with this PR label Sep 4, 2024
@mesellings
Copy link
Contributor

@jwulf I'll take a look at this for you 👍

@github-actions github-actions bot temporarily deployed to camunda-docs September 4, 2024 09:39 Destroyed
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates lgtm - happy to approve 👍

@mesellings mesellings self-assigned this Sep 4, 2024
@akeller akeller merged commit 5ac20fd into main Sep 6, 2024
16 checks passed
@akeller akeller deleted the update-node-client branch September 6, 2024 16:32
Copy link
Contributor

github-actions bot commented Sep 6, 2024

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content deploy Stand up a temporary docs site with this PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants