-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Go and CLI client to community section #4228
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
@akeller as we have a first RC release of the community client I would rebase this PR and add commits on top to adjust the module name (which changed with the move) accordingly for the |
@megglos just to confirm, you will do the rebasing, correct? Do you want to take over assignee? |
9f7d4f2
to
1a5d749
Compare
de91f13
to
ecb5db4
Compare
@akeller I updated all zbctl links to the new community location, as it's not an official tool anymore with 8.6 I will replace this with the equivalent REST API reference next with camunda/camunda#22665 |
@akeller can't request review as you were the creator of the PR 🙈 can you still take a look? |
Approaching the end of my day here, I will review this tomorrow with fresh eyes. |
Structurally, this looks good. There are some additional pieces I'd like to see cleaned up, including softening the language that makes the CLI client look officially supported:
Instead, say something like:
It's subtle and something we can make more overt if we need to (adding an admonition). |
@megglos Shall I make these language softening changes for you, or have you already started making them? |
@mesellings |
Will do, hope you feel better soon 👍 |
@mesellings - I'm happy with this. We can always monitor if it needs something stronger/louder. Thank you! |
@aleksander-dytko - do we need to add text about how these tools are deprecated? Or link to the release notes and/or blog about deprecation? @leiicamundi made a good point on another PR that we should be clear about this, even if it will be community-supported. |
Adjusted in latest commit. |
@aleksander-dytko please review so we can merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm 👍 🚀
@akeller do you want me to merge this? |
@mesellings I almost said yes, but I just realized this PR doesn't have redirects for the moved content. |
56fed94
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The redirects lgtm 👍
🧹 Preview environment for this PR has been torn down. |
* structural move, link adjustment * fix links * add Go and CLI client to community overview * removal of Go deprecation warnings for new community home * adopt go client packages to community module * go client link to community repo * go client updated go environment version * zeebe cli update path to community repository releases * set all links to zeebe cli * removal of attention comment, go client 8.5 is supported * Add links to moved client to announcements * go client, fix links to source files * removal of go client and zbctl from security setup * Add community-supported clarification * add redirects for /next/ --------- Co-authored-by: Meggle (Sebastian Bathke) <[email protected]> Co-authored-by: mesellings <[email protected]>
Description
Structural move for https://github.com/camunda/product-hub/issues/2438.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).