-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(self-managed): drop support of openshift 4.12 and add support of openshift 4.16 #4224
Conversation
also fix a typo on the note
@leiicamundi I will review this for you 👍 |
@leiicamundi I notice you talk about dropping 4.13 support, but have only removed the 4.12 table row - just want to confirm this is correct? |
Hi @mesellings, it's a error on my side, I was referring to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leiicamundi I've made review edits directly in the branch:
- Fixed list indentation and numbering
- Some grammar, text changes
Happy to approve 👍
Thank you, @mesellings! I really appreciate the improvements you made to this doc. 😊 I'll ask either @jessesimpson36 or @Langleu to do a second review from the support perspective. @theburi, just for your information, we’ve added OpenShift 4.16 to the support matrix and removed version 4.12 (which is now EOL). This is part of our standard maintenance cycle. Could you please approve this change? Also, @mesellings, I'll have limited access to my computer this week. Please feel free to merge the PR if needed once everyone has validated it. Thank you! |
tls: | ||
enabled: true | ||
secretName: camunda-platform-external-certificate | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems pretty inconsistent. do you prefer indented codeblocks or non-indented codeblocks?
https://github.com/camunda/camunda-docs/pull/4224/files#diff-a2f46593f55132fad493be0c88dcd7ae6aa247e7afaf0bf345d2102fb9161661R76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with the changes. Personally, I would have preferred if the git-diff wasn't littered with indentation changes but what matters moreso to me is the rendered docs, and those changes are good content.
Thank you - the indentation is (unfortunately) required by Docusaurus to nest code blocks etc with the relevant list item - I agree it looks messy, but is just how Docusaurus allows you to nest inside lists. For example, to have the code block align with the prior list item, you need to add 3 spaces as an indent to trigger this, otherwise it is placed 'outside' the list. |
🧹 Preview environment for this PR has been torn down. |
Description
OpenShift 4.12 is out of our support matrix since the EOL of the version.
OpenShift 4.16 has been released and tested on our side (camunda/camunda-platform-helm#2131).
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).