Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the SM update guide #4190

Merged
merged 10 commits into from
Aug 30, 2024
Merged

Reorganize the SM update guide #4190

merged 10 commits into from
Aug 30, 2024

Conversation

conceptualshark
Copy link
Contributor

@conceptualshark conceptualshark commented Aug 22, 2024

Description

This has NOT yet been backported, to spare me reproducing any work that results of review. Looking for feedback on this new structure - review the 8.5 version of this page for comparison.

Goals here are to:

  • condense the update guide information into tabs (to determine later if individual pages/organization with the other other update guides would be helpful)
  • reorganize the content to flow more linearly in terms of requirement
  • Add additional information and links to get users where they need to be earlier in the process

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@conceptualshark conceptualshark self-assigned this Aug 22, 2024
Copy link
Contributor

github-actions bot commented Aug 22, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@conceptualshark conceptualshark added component:docs Documentation improvements, including new or updated content component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed deploy Stand up a temporary docs site with this PR labels Aug 22, 2024
@conceptualshark conceptualshark marked this pull request as ready for review August 22, 2024 20:45
@conceptualshark conceptualshark requested a review from a team August 22, 2024 20:46
@github-actions github-actions bot temporarily deployed to camunda-docs August 22, 2024 21:01 Destroyed
Comment on lines +43 to +45
{label: 'From Camunda 8.4 to 8.5', value: '8.5', },
{label: 'From Camunda 8.3 to 8.4', value: '8.4', },
{label: 'From Camunda 8.2 to 8.3', value: '8.3', },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the /next/ version, you would want to include 8.6, right? Or is this just reorganizing the current content only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reorg of the current only - I don't think we have any notes yet for what config changes will be required in 8.5 > 8.6.

Co-authored-by: Amara Graham <[email protected]>
@github-actions github-actions bot temporarily deployed to camunda-docs August 23, 2024 13:10 Destroyed
@akeller akeller requested a review from a team August 26, 2024 13:57
@@ -2,130 +2,61 @@
id: upgrade
title: "Camunda 8 Helm upgrade"
sidebar_label: "Upgrade"
description: "To upgrade to a more recent version of the Camunda Helm charts, there are certain things you need to keep in mind."
description: "Upgrade to a more recent version of the Camunda Helm charts."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I LOVE that you've tidied this up something significantly cleaner. This is a nitpick, but I try to shoot for ~150 characters for SEO purposes 👍

In the error message, Bitnami links to their [troubleshooting guide](https://docs.bitnami.com/general/how-to/troubleshoot-helm-chart-issues/#credential-errors-while-upgrading-chart-releases). However, to avoid confusion, we will step through the troubleshooting process in this guide as well.

### Secrets extraction
For a smooth upgrade experience, we recommend determining both your **Helm chart** and **Helm CLI** versions prior to starting your upgrade.
Copy link
Contributor

@christinaausley christinaausley Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a very strong recommendation, or can we just say "For a smooth upgrade experience, determine your Helm chart and Helm CLI versions prior to starting your upgrade."? I try to stray away from "we recommend" if it is a stronger command, if that makes sense? See this PR for some context.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe another distribution team member might have other opinions, but I don't think we're that strict on helm CLI versions. I know from reading commits on helm that they haven't added any new features in the past year, so if someones on ubuntu and installed apt install helm and that version of helm isn't like, 3 years old, I wouldn't expect issues. But the notice could be there simply to let people know the helm versions we're testing with.

@akeller
Copy link
Member

akeller commented Aug 28, 2024

@conceptualshark, do you need us to take a second pass to review this PR? Can you clean up the conflicts?

@conceptualshark
Copy link
Contributor Author

@akeller I'm curious if you think I should get an engineering review on this? 🤔 Otherwise I can make the recommended updates and backport!

@akeller
Copy link
Member

akeller commented Aug 29, 2024

@akeller I'm curious if you think I should get an engineering review on this? 🤔 Otherwise I can make the recommended updates and backport!

Yes, probably good to bring in someone from the Distribution team to review this PR @conceptualshark

@conceptualshark
Copy link
Contributor Author

@jessesimpson36 Do you mind taking a look at this, or recommending someone to review? Reorganizing the Update guide to make it a little easier to follow, so ideally it will still make sense!


- [Desktop Modeler](/components/modeler/desktop-modeler/connect-to-camunda-8.md).
- [Zeebe client (zbctl)](/self-managed/zeebe-deployment/security/secure-client-communication.md#zbctl).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I originally added the above section because I wanted customers to validate that their upgrade was successful, and when I'm testing upgrades, I often test by doing those steps. I'd hope to see this content again in another form, if not specified here.

Deploying a model covers scenarios where all the applications pods status report healthy, but maybe theres some communication issue between pods.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that is useful to validate/test for every upgrade? Right now it's removed because it was only listed in the 8.1 -> 8.2 upgrade section, which is removed here because 8.1 is no longer supported. If a validation section would be useful in general, I can make another issue to add something to this guide for it.

@jessesimpson36
Copy link
Contributor

jessesimpson36 commented Aug 30, 2024

I've given my thoughts. Overall I like the change, and find the tabs to be a less cluttered experience than the lengthy sidebar. I don't want you to change anything regarding my above comment, but just keep it in mind. (or adjust at your discretion).

jessesimpson36
jessesimpson36 previously approved these changes Aug 30, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs August 30, 2024 15:35 Destroyed
@conceptualshark
Copy link
Contributor Author

Ready for a final(?) review here - I've only backported to 8.5, as we don't use the same style for the guide prior to that version. I'm not sure if it would be worth updating 8.2 - 8.4 as part of this PR/in general.

@github-actions github-actions bot temporarily deployed to camunda-docs August 30, 2024 15:55 Destroyed
@conceptualshark conceptualshark merged commit 93c62d3 into main Aug 30, 2024
9 checks passed
@conceptualshark conceptualshark deleted the cg-tabbed-update-guide branch August 30, 2024 16:34
Copy link
Contributor

🧹 Preview environment for this PR has been torn down.

@akeller
Copy link
Member

akeller commented Aug 30, 2024

Ready for a final(?) review here - I've only backported to 8.5, as we don't use the same style for the guide prior to that version. I'm not sure if it would be worth updating 8.2 - 8.4 as part of this PR/in general.

Late to the party, but for backporting large changes like this, I usually recommend doing exactly what you did - current and next versions only. Smaller changes that are easier (or critical) to update can be backported to all supported versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed deploy Stand up a temporary docs site with this PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants