-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize the SM update guide #4190
Conversation
👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉 You can read more about the versioning within our docs in our documentation guidelines. |
{label: 'From Camunda 8.4 to 8.5', value: '8.5', }, | ||
{label: 'From Camunda 8.3 to 8.4', value: '8.4', }, | ||
{label: 'From Camunda 8.2 to 8.3', value: '8.3', }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is the /next/ version, you would want to include 8.6, right? Or is this just reorganizing the current content only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reorg of the current only - I don't think we have any notes yet for what config changes will be required in 8.5 > 8.6.
Co-authored-by: Amara Graham <[email protected]>
docs/self-managed/setup/upgrade.md
Outdated
@@ -2,130 +2,61 @@ | |||
id: upgrade | |||
title: "Camunda 8 Helm upgrade" | |||
sidebar_label: "Upgrade" | |||
description: "To upgrade to a more recent version of the Camunda Helm charts, there are certain things you need to keep in mind." | |||
description: "Upgrade to a more recent version of the Camunda Helm charts." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I LOVE that you've tidied this up something significantly cleaner. This is a nitpick, but I try to shoot for ~150 characters for SEO purposes 👍
In the error message, Bitnami links to their [troubleshooting guide](https://docs.bitnami.com/general/how-to/troubleshoot-helm-chart-issues/#credential-errors-while-upgrading-chart-releases). However, to avoid confusion, we will step through the troubleshooting process in this guide as well. | ||
|
||
### Secrets extraction | ||
For a smooth upgrade experience, we recommend determining both your **Helm chart** and **Helm CLI** versions prior to starting your upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a very strong recommendation, or can we just say "For a smooth upgrade experience, determine your Helm chart and Helm CLI versions prior to starting your upgrade."? I try to stray away from "we recommend" if it is a stronger command, if that makes sense? See this PR for some context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe another distribution team member might have other opinions, but I don't think we're that strict on helm CLI versions. I know from reading commits on helm that they haven't added any new features in the past year, so if someones on ubuntu and installed apt install helm
and that version of helm isn't like, 3 years old, I wouldn't expect issues. But the notice could be there simply to let people know the helm versions we're testing with.
@conceptualshark, do you need us to take a second pass to review this PR? Can you clean up the conflicts? |
@akeller I'm curious if you think I should get an engineering review on this? 🤔 Otherwise I can make the recommended updates and backport! |
Yes, probably good to bring in someone from the Distribution team to review this PR @conceptualshark |
@jessesimpson36 Do you mind taking a look at this, or recommending someone to review? Reorganizing the Update guide to make it a little easier to follow, so ideally it will still make sense! |
|
||
- [Desktop Modeler](/components/modeler/desktop-modeler/connect-to-camunda-8.md). | ||
- [Zeebe client (zbctl)](/self-managed/zeebe-deployment/security/secure-client-communication.md#zbctl). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I originally added the above section because I wanted customers to validate that their upgrade was successful, and when I'm testing upgrades, I often test by doing those steps. I'd hope to see this content again in another form, if not specified here.
Deploying a model covers scenarios where all the applications pods status report healthy, but maybe theres some communication issue between pods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something that is useful to validate/test for every upgrade? Right now it's removed because it was only listed in the 8.1 -> 8.2 upgrade section, which is removed here because 8.1 is no longer supported. If a validation section would be useful in general, I can make another issue to add something to this guide for it.
I've given my thoughts. Overall I like the change, and find the tabs to be a less cluttered experience than the lengthy sidebar. I don't want you to change anything regarding my above comment, but just keep it in mind. (or adjust at your discretion). |
Ready for a final(?) review here - I've only backported to 8.5, as we don't use the same style for the guide prior to that version. I'm not sure if it would be worth updating 8.2 - 8.4 as part of this PR/in general. |
🧹 Preview environment for this PR has been torn down. |
Late to the party, but for backporting large changes like this, I usually recommend doing exactly what you did - current and next versions only. Smaller changes that are easier (or critical) to update can be backported to all supported versions. |
Description
This has NOT yet been backported, to spare me reproducing any work that results of review. Looking for feedback on this new structure - review the 8.5 version of this page for comparison.
Goals here are to:
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).