Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test adding option to hide docusaurus tabs #4173

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

conceptualshark
Copy link
Contributor

@conceptualshark conceptualshark commented Aug 20, 2024

Description

Add the new hidden tabs CSS class, and update the existing incident variables page to use it!

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Copy link
Contributor

github-actions bot commented Aug 20, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@conceptualshark conceptualshark changed the title add css to hide tabs, update page to test Test adding option to hide docusaurus tabs Aug 20, 2024
@conceptualshark conceptualshark self-assigned this Aug 20, 2024
@conceptualshark conceptualshark added hold This issue is parked, do not merge. dx Documentation infrastructure typically handled by the Camunda DX team deploy Stand up a temporary docs site with this PR labels Aug 20, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs August 20, 2024 13:04 Destroyed
@conceptualshark conceptualshark requested review from a team and pepopowitz August 28, 2024 13:30
@akeller
Copy link
Member

akeller commented Aug 28, 2024

Thanks for bringing this to the team meeting! 🚀

@conceptualshark conceptualshark removed the hold This issue is parked, do not merge. label Aug 28, 2024
@conceptualshark conceptualshark marked this pull request as ready for review August 28, 2024 20:10
@conceptualshark
Copy link
Contributor Author

@camunda/tech-writers @pepopowitz This should be good to go. In the example page, I left the final tab option unhidden, because I think it's far enough removed from the initial tabs selection that the reminder is helpful.

Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YESSSS!

I love this. Non-blocking (but please create an issue to follow up), we should add guidance on how/when to hid or not hide tabs. Somewhere in https://github.com/camunda/camunda-docs/tree/main/howtos (maybe markdown & mdx?).

@github-actions github-actions bot temporarily deployed to camunda-docs August 28, 2024 20:39 Destroyed
@conceptualshark conceptualshark merged commit 52548f2 into main Aug 28, 2024
7 checks passed
@conceptualshark conceptualshark deleted the cg-poc-tabs branch August 28, 2024 20:48
Copy link
Contributor

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Stand up a temporary docs site with this PR dx Documentation infrastructure typically handled by the Camunda DX team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants