Guide for DB interceptor plugins #4171
Conversation
igpetrov
added
component:zeebe
|
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
| ```xml | ||
| <dependency> | ||
| <groupId>io.camunda</groupId> | ||
| <artifactId>camunda-search-plugins</artifactId> |
There was a problem hiding this comment.
I found it confusing at first that it's "search" plugin. Do you refer to OpenSearch and Elastic or why search? Isn't it more about the database? camunda-db-plugins e.g.?
|
generally lgtm, pre-approving, just one comment |
There was a problem hiding this comment.
I restructured this page and made some edits, and will pre-approve if these changes look good to you. 👍 I also agree with @felix-mueller that this should live in the config/install guides at the moment.
|
@felix-mueller @conceptualshark Fair point, and that was my thought as well and the only alternative I considered was |
|
The |
|
@igpetrov Is this ready for another review, or still in progress? |
|
Please, give me few more moments, I'll need to move the page and then we can merge. |
|
ah, okay, page is on the right spot. Then all good! Let's go with the final review and ready to merge |
| import Tabs from "@theme/Tabs"; | ||
| import TabItem from "@theme/TabItem"; | ||
|
|
||
| Custom HTTP headers can be added to a component's Elasticsearch and OpenSearch HTTP clients by creating a new Java plugin, and adding the plugin to your Camunda 8 Self-Managed installation. Using custom HTTP headers may be helpful for adding authentication, tracking, or debugging to your database requests. |
There was a problem hiding this comment.
Do we need to add for now that it's not supported for Optimize???
There was a problem hiding this comment.
I was expecting for onboarding Optimize before 8.6. For now, we do not include Optimize config value. @felix-mueller do you think, we should explicitly mention Optimize not included?
|
Lets merge then without. Thanks
Am 27.08.2024 18:34 schrieb Igor Petrov ***@***.***>:
@igpetrov commented on this pull request.
________________________________
In docs/self-managed/setup/guides/configure-db-custom-headers.md<#4171 (comment)>:
@@ -0,0 +1,215 @@
+---
+id: configure-db-custom-headers
+title: "Configure custom headers"
+sidebar_label: "Configure custom headers"
+description: "Learn how to configure DB client custom headers"
+---
+
+import Tabs from ***@***.***/Tabs";
+import TabItem from ***@***.***/TabItem";
+
+Custom HTTP headers can be added to a component's Elasticsearch and OpenSearch HTTP clients by creating a new Java plugin, and adding the plugin to your Camunda 8 Self-Managed installation. Using custom HTTP headers may be helpful for adding authentication, tracking, or debugging to your database requests.
I was expecting for onboarding Optimize before 8.6. For now, we do not include Optimize config value. @felix-mueller<https://github.com/felix-mueller> do you think, we should explicitly mention Optimize not included?
—
Reply to this email directly, view it on GitHub<#4171 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AE2YDSBLAMVNO6MTBASVUKDZTSTAFAVCNFSM6AAAAABMYCUHJWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENRTHE2TGNBSHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Description
Related to epic: https://github.com/camunda/product-hub/issues/563
When should this change go live?
The PR should be merged after this PR: camunda/camunda#20794 which we anticipate to happen during the week of August 19th. We're targeting
8.6.0-alpha5release.holdlabel or convert to draft PR): will be merged after feat: initial code for plugin architecture camunda#20794 approved.PR Checklist
My changes are for an already released minor and are in
/versioned_docsdirectory.My changes are for the next minor and are in
/docsdirectory (aka/next/).I included my new page in the sidebar file(s).
I added a redirect for a renamed or deleted page to the .htaccess file.